bug: connection string example is inconsistent with implementation

[houz42]

The document shows an example connection string:

s3://?credential=hmac:xxxx:xxxx&endpoint=http://s3.us-east-2.amazonaws.com

While the endpoint in it will not be parsed correctly by the s3 service.
The s3 service uses go-endpoint to parse the endpoint value, which defines endpoints as the form of http:s3.us-east-2.amazonaws.com, no // after the http:

I am using:

• go-storage: v4.4.1
• s3-service: v2.3.0

By the way, I'am happy to fix it, but not sure which solution is preferred:

• make go-endpoint respect the // notation,
• or update the doc

[Xuanwo]

Oooops, our docs is incorrect.

We need to use http:s3.us-east-2.amazonaws.com here.

Can you send a PR to site to fix it? Thanks so much!

[Xuanwo]

And the problem is so common that we are considering add support for :// too.

Tracked at beyondstorage/go-endpoint#15

[Xuanwo]

For your convenience: the docs located at https://github.com/beyondstorage/site/blob/master/docs/go-storage/operations/index.md

GitHub

site/index.md at master · beyondstorage/site

Source files of https://beyondstorage.io. Contribute to beyondstorage/site development by creating an account on GitHub.

[Xuanwo]

Fixed in beyondstorage/site#192, thanks for report!