This repository was archived by the owner on Oct 22, 2021. It is now read-only.
Idempotent storager delete operation #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
May 7, 2021
error.go
Outdated
| // ref: https://cloud.tencent.com/document/product/436/7730 | ||
| const ( | ||
| // NoSuchKey the specified key does not exist. | ||
| NoSuchKey = "NoSuchKey" |
There was a problem hiding this comment.
Please don't export SDK errors
storage.go
Outdated
| @@ -27,6 +27,11 @@ func (s *Storage) delete(ctx context.Context, path string, opt pairStorageDelete | |||
|
|
|||
| _, err = s.object.Delete(ctx, rp) | |||
| if err != nil { | |||
| if e, ok := err.(*cos.ErrorResponse); ok { | |||
There was a problem hiding this comment.
Please extrace a checkError(err error, code string) bool
Xuanwo
approved these changes
May 7, 2021
13 tasks
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idempotent storager delete operation in ref: beyondstorage/go-storage#554.