This repository was archived by the owner on Oct 22, 2021. It is now read-only.
feat: Setup Integration tests #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This integration tests seems can't pass. I updated account in 1password, please test locally at first. |
|
ping @Xuanwo to add integration tests for azfile in teamcity. |
JinnyYi
reviewed
Sep 18, 2021
Makefile.env.example
Outdated
| @@ -0,0 +1,4 @@ | |||
| export STORAGE_AZFILE_INTEGRATION_TEST=on | |||
| export STORAGE_AZFILE_CREDENTIAL=hmac:account_name:account_key | |||
| export STORAGE_AZFILE_NAME=shareURL name | |||
There was a problem hiding this comment.
How about using sharename to keep them in the same style?
JinnyYi
reviewed
Sep 18, 2021
tests/README.md
Outdated
Comment on lines
22
to
24
| export STORAGE_AZFILE_INTEGRATION_TEST=on | ||
| export STORAGE_AZFILE_CREDENTIAL=hmac:account_name:account_key | ||
| export STORAGE_AZFILE_ENDPOINT=https:accountname.file.core.windows.net |
There was a problem hiding this comment.
Missing STORAGE_AZFILE_NAME here?
Xuanwo
reviewed
Sep 18, 2021
|
Looks so nice! Can you also update the README? |
Got it, I will update the README. |
|
Nice job! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Setup Integration tests