Skip to content

RN-963 Meditrak ios features #5143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

IgorNadj
Copy link
Contributor

@IgorNadj IgorNadj commented Nov 6, 2023

Issue #: RN-963

As far as I can tell the only thing missing from Meditrak iOS that is in Meditrak Android was saving QR codes to camera roll.

Green build: https://appcenter.ms/orgs/Beyond-Essential/apps/Tupaia-MediTrak/build/branches/rn-963-meditrak-ios-features/builds/268

CI/CD issues will fixed in bump-node-to-v16 branch

Screenshots in card.

@IgorNadj IgorNadj force-pushed the rn-963-meditrak-ios-features branch from ca32621 to 75e751e Compare November 6, 2023 00:27
Copy link
Member

@edmofro edmofro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@IgorNadj IgorNadj merged commit 9f5cac2 into rn-973-upgrade-meditrak20 Nov 6, 2023
@IgorNadj IgorNadj deleted the rn-963-meditrak-ios-features branch November 6, 2023 02:06
IgorNadj added a commit that referenced this pull request Nov 6, 2023
* Save QR codes to camera roll

* Set BES as the dev team for the ios app

XCode > Signing & Capabilities

* Typo

* Rm unused package react-native-file-access
IgorNadj added a commit that referenced this pull request Nov 24, 2023
* Prerequisite: node v16+ (selected v16.20.2)

Tried v20 but node 18 has breaking changes which break react-native-dotenv, see goatandsheep/react-native-dotenv#468

* npx react-native@latest init TupaiaMediTrak

* Rename new package, add to workspace, nohoist it

* Add info for devs in README

* cp -r meditrak-app/app meditrak-app-new/app

* find . -name '*.js' -exec sh -c 'mv -zsh -zsh.jsx' {} \;

* Copy project root files from meditrak-app to meditrak-app-new

* Rm meditrak-app/package.json.

This was needed because trying to install newer versions of tools e.g. node-gpy was not working while older versions were already installed + each runs on different versions of node.

* Copy package.json deps from meditrak-app to meditrak-app-new

* Rm deprecated packages

* Fix nanoid import after upgrade

* Temporarily stub out appcenter and bugsnag

* Rm unused package-lock.json

* Add missing package @babel/plugin-proposal-export-default-from

* Swap react-native-dotenv out for react-native-config

react-native-dotenv wasnt working with node 16

* Fix module resolution

* Upgrade Realm model definitions for new version

* Add missing peer deps

* Bump version

* Minor: Ignore react warnings

These will need to be dealt with in an upgrade to the app itself

* Re-setup react-native-vector-icons

* Reimplement QR code scan

Using new non-deprecated package react-native-vision-camera

* Downgrade nanoid to restore functionality

* Copy over all permissions from old app AndroidManifest

* Fix nanoid import

* Update PhotoQuestion for upgraded react-native-image-picker

* Fix icon

* Minor: Add notes on env vars and reset-cache script

* Setup ios: Copy config from old app, version number

* Set app name and icons

* Bump node version

* rm -fr packages/meditrak-app && mv packages/meditrak-app-new packages/meditrak-app

* Rename @tupaia/meditrak-app-new to @tupaia/meditrak-app

* Fix android build on AppCenter

* Hack: use node14 for meditrak-app only

Node will be bumped globally in RN-1090

* RN-963 Meditrak ios features (#5143)

* Save QR codes to camera roll

* Set BES as the dev team for the ios app

XCode > Signing & Capabilities

* Typo

* Rm unused package react-native-file-access

* Bump version

* Update iOS Encryption compliance

See https://stackoverflow.com/a/46691541

MediTrak does use encryption (HTTPS api calls), but is exempt from Exporter Registration and Reporting (ERN) process, see
https://stackoverflow.com/a/16080233

* Bump version

* Bump Meditrak App version

* Add missing dep

* Bump Meditrak version

* Fix build issue by removing global package:build:react-scripts, setting specific yargs version at top level

* Add dep directly to fix babel error

* Add dep directly to fix build issue

* Add missing dep

* Add missing deps

* Add missing deps for ui-map-components

* Lock down @babel/types version

Fixes issue with incompatible versions clashing, see babel/babel#15765 (comment)

* Reimplement Bugsnag

* Reimplement Appcenter analytics

* Bump version

* Fix bugsnag config, pod install

* Remove RN launch screen text

* Bump version

* Add missing nvmrc

* Bump realm to fix install issue

* Rm obsolete resolutions override

* Bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants