RN-702: Re-instate excluding columns when using the 'exclude' merge function #4248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It was never used in practice, and made the code more complex
…ves the column from the table
rohan-bes
force-pushed
the
rn-702-reinstate-exclude-cols
branch
from
a250dd8 to
d4b4c58
Compare
IgorNadj
reviewed
Jan 10, 2023
| @@ -121,31 +121,6 @@ describe('parser', () => { | |||
| }); | |||
|
|
|||
| describe('in transforms', () => { | |||
| it('mergeRows supports parser lookups on where', () => { | |||
There was a problem hiding this comment.
Do we need a new test for mergeStrategy = exclude?
There was a problem hiding this comment.
Ah good call! I'll re-add them, thanks 👍
There was a problem hiding this comment.
Ah wait sorry, we do actually have the test for exclude removing the columns from the table
IgorNadj
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue RN-702:
Just re-introducing some behaviour that got removed as part of RN-175.
Also scrapped the
whereclause support onmergeRows, as it's never been used and makes the code more complex than needed