Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN-484: Add ability for defining 'custom reports' in the report-server #4090

Merged
merged 4 commits into from
Sep 6, 2022
Merged

RN-484: Add ability for defining 'custom reports' in the report-server #4090

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2aa1f26
RN-484: Added support for 'customReports' in the report-server
rohan-bes Aug 16, 2022
6f7856d
RN-484: Added tests for testCustomReport
rohan-bes Aug 16, 2022
950fc28
RN-484: Refactored code in admin-panel-server to be more DRY
rohan-bes Aug 16, 2022
0d25973
RN-484: Removed custom styling for CustomReportName div
rohan-bes Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
RN-484: Removed custom styling for CustomReportName div
  • Loading branch information
@rohan-bes
rohan-bes committed Sep 6, 2022
commit 0d25973188833258e3abbe41efc8ba1cf8d549b5
13 changes: 1 addition & 12 deletions packages/admin-panel/src/VizBuilderApp/components/Panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,17 +76,6 @@ const PanelTabPanel = styled.div`
}
`;

const CustomReportName = styled.span`
flex: 1;
display: flex;
flex-direction: column;

> div {
width: 100%;
height: 100%;
}
`;

export const Panel = () => {
const { hasDataError, setDataError } = useVizConfigError();
const { jsonToggleEnabled } = useTabPanel();
Expand Down Expand Up @@ -125,7 +114,7 @@ export const Panel = () => {
return (
<Container>
<PanelNav>
<CustomReportName>Custom Report: {vizData.customReport}</CustomReportName>
<>Custom Report: {vizData.customReport}</>
<PlayButton />
</PanelNav>
</Container>
Expand Down