Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN-400: Meditrak permissions based sync (server-side changes) #3992

Merged
merged 16 commits into from
Aug 12, 2022
Merged

RN-400: Meditrak permissions based sync (server-side changes) #3992

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
f0f93c8
RN-400: Added array_concat_agg postgres aggregation functions for com…
rohan-bes Jun 23, 2022
3dc7a58
RN-400: Added permissions_based_meditrak_sync_queue
rohan-bes Jun 23, 2022
142d595
RN-400: Aded MeditrakSyncQueue ChangeHandler which manages the
rohan-bes Jun 23, 2022
163f85f
RN-400: Changed SqlQuery.array() to SqlQuery.record()
rohan-bes Jun 23, 2022
8e9c7ce
RN-400: Added logic to filter syncing by only data the device has per…
rohan-bes Jun 23, 2022
aeceffc
RN-400: Fix tests
rohan-bes Jun 23, 2022
7662117
RN-400: Renamed 'getChangesFilter'
rohan-bes Jul 28, 2022
a9979fe
RN-400: Addressed PR comments
rohan-bes Jul 28, 2022
8c4f290
RN-400: Switch to CREATE OR REPLACE aggregate
rohan-bes Jul 29, 2022
05aa2e9
RN-400: Meditrak permissions based sync (app-side changes) (#3995)
rohan-bes Aug 2, 2022
08302b3
RN-400: Fixed not all data syncing if user permissions change
rohan-bes Aug 5, 2022
da0e877
RN-400: Reworked permissions based sync query building
rohan-bes Aug 8, 2022
b3e8c08
RN-400: Reverted change to use permissions based sync on changes/coun…
rohan-bes Aug 9, 2022
56df105
RN-400: Added unit tests for permissions based sync
rohan-bes Aug 5, 2022
7a657ae
RN-400: Moved building of permissions based meditrak sync queue view …
rohan-bes Aug 12, 2022
9f6da9b
Merge branch 'dev' into rn-400-permissions-based-sync-p1
rohan-bes Aug 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
RN-400: Fixed not all data syncing if user permissions change 
- countChanges wasn't using permissions based sync, so thought there were 0 changes
  • Loading branch information
@rohan-bes
rohan-bes committed Aug 5, 2022
commit 08302b3803a2df3df5ef8d278c31301fb6d16066
11 changes: 9 additions & 2 deletions packages/central-server/src/apiV2/countChanges/countChanges.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,21 @@
*/

import { respond, DatabaseError, UnauthenticatedError } from '@tupaia/utils';
import { buildMeditrakSyncQuery } from '../utilities';
import {
buildMeditrakSyncQuery,
buildPermissionsBasedMeditrakSyncQuery,
supportsPermissionsBasedSync,
} from '../utilities';
import { LegacyCountChangesHandler } from './LegacyCountChangesHandler';
import { allowNoPermissions } from '../../permissions';

const handleNonLegacyRequest = async (req, res) => {
const { models } = req;

const { query } = await buildMeditrakSyncQuery(req, { select: 'count(*)' });
const queryBuilder = supportsPermissionsBasedSync(req.query.appVersion)
? buildPermissionsBasedMeditrakSyncQuery
: buildMeditrakSyncQuery;
const { query } = await queryBuilder(req, { select: 'count(*)' });
const queryResult = await query.executeOnDatabase(models.database);
const changeCount = parseInt(queryResult[0].count);
respond(res, { changeCount });
Expand Down