Refactor tests for survey response import #3578
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[No issue]
Not strictly required but in preparation for PHX-152, I felt that it would be worth refactoring the survey response import tests. Reasons:
Changes overview
duplicate_quest_id1_test
) instead of the existing, more realistic ids (egfdfcc42a44705c032a8_test
)Public
permission group to a survey when permissions are not tested, etc)