Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHX-97: Add date features in report server #3341

Merged
merged 14 commits into from
Oct 10, 2021

Conversation

kael89
Copy link
Collaborator

@kael89 kael89 commented Oct 5, 2021

Issue #:

PHX-97

Changes:

  • Extracted offset calculation functionality in utils
  • Added QueryBuilder in report-server, which is responsible for parsing and sanitising the input query
  • Added config validator in report-server
  • Refactored a few report-server types
  • Added custom function in expression-parser: date

@kael89 kael89 marked this pull request as ready for review October 6, 2021 23:41
@kael89 kael89 force-pushed the phx-97-add-date-features-in-report-server branch from e8f7a61 to ea18364 Compare October 7, 2021 20:48
Copy link
Collaborator

@rohan-bes rohan-bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @kael89 This is great!!

I had a few comments here and there about typescript things, but nothing major 👍 Really love all the thorough tests, and the abstracted out logic 👍

@kael89
Copy link
Collaborator Author

kael89 commented Oct 10, 2021

@rohan-bes I updated our custom functions in expression-parser to support undefined values (currently they only support the 'undefined' string for this purpose: 6cfd4ac

@kael89 kael89 merged commit e29e3dd into dev Oct 10, 2021
@kael89 kael89 deleted the phx-97-add-date-features-in-report-server branch October 10, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants