-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHX-97: Add date features in report server #3341
Conversation
packages/admin-panel-server/src/viz-builder/dashboardVisualisation/combineVisualisation.ts
Show resolved
Hide resolved
packages/admin-panel-server/src/viz-builder/dashboardVisualisation/reportConfigValidator.ts
Show resolved
Hide resolved
packages/admin-panel-server/src/viz-builder/dashboardVisualisation/reportConfigValidator.ts
Outdated
Show resolved
Hide resolved
e8f7a61
to
ea18364
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @kael89 This is great!!
I had a few comments here and there about typescript things, but nothing major 👍 Really love all the thorough tests, and the abstracted out logic 👍
packages/admin-panel-server/src/viz-builder/dashboardVisualisation/combineVisualisation.ts
Show resolved
Hide resolved
packages/admin-panel-server/src/viz-builder/dashboardVisualisation/reportConfigValidator.ts
Outdated
Show resolved
Hide resolved
packages/admin-panel-server/src/viz-builder/dashboardVisualisation/reportConfigValidator.ts
Show resolved
Hide resolved
packages/expression-parser/src/expression-parser/ExpressionParser.js
Outdated
Show resolved
Hide resolved
@rohan-bes I updated our custom functions in |
Issue #:
PHX-97
Changes:
utils
QueryBuilder
in report-server, which is responsible for parsing and sanitising the input querydate