Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hoftix: Fix new viz save #3324

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Hoftix: Fix new viz save #3324

merged 2 commits into from
Oct 4, 2021

Conversation

kael89
Copy link
Collaborator

@kael89 kael89 commented Oct 4, 2021

@kael89 kael89 changed the title Hoftix: Fix viz save Hoftix: Fix new viz save Oct 4, 2021
rohan-bes
rohan-bes approved these changes Oct 4, 2021
View reviewed changes
Copy link
Collaborator

@rohan-bes rohan-bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rohan-bes
rohan-bes reviewed Oct 4, 2021
View reviewed changes
...admin-panel-server/src/viz-builder/dashboardVisualisation/DashboardVisualisationExtractor.ts
@@ -77,7 +77,7 @@ export class DashboardVisualisationExtractor<
name,
},
reportCode: code,
legacy,
legacy: !!legacy,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this means it's defaults to not legacy? That seems correct...

@tcaiger tcaiger merged commit 0c2c662 into release-2021-39 Oct 4, 2021
@tcaiger tcaiger deleted the hotfix-save-new-viz branch October 4, 2021 19:56
tcaiger added a commit that referenced this pull request Oct 4, 2021
@tcaiger @biaoli0 @kael89
Master (#3329)
1afc936 
* No issue - Fix tupaia mobile not showing page (#3322)

* Update MarkerLayer.js (#3323)

* Hoftix: Fix new viz save (#3324)

* Fix viz save

* Fix in extractor

Co-authored-by: Biao Li <31789355+billli0@users.noreply.github.com>
Co-authored-by: Kostas Karvounis <kael89@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohan-bes rohan-bes rohan-bes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kael89 @rohan-bes @tcaiger