Bugfix: Check value of kobo disable var, not just existence #3035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kael89
approved these changes
Aug 18, 2021
BinduMadhaviTammireddy
added a commit
that referenced
this pull request
Aug 19, 2021
PShoe
added a commit
that referenced
this pull request
Aug 19, 2021
* create project card pacmossi * Update 20210816012839-AddProjectPacmossi-modifies-data.js * add second userGroup * Add project details dashboard item to project * Add Tonga to list * update to match dashboard code patterns * entityHierarchyId refactor * Update 20210816012839-AddProjectPacmossi-modifies-data.js * add canonical types * fix canonical_types error * fix sort order * pacmossi-project-card test (#3038) * NZ-2: Add migration for 40 target districts (#2988) * Check value of kobo disable var, not just existence (#3035) Co-authored-by: Ethan McQuarrie <69437175+EMcQ-BES@users.noreply.github.com> Co-authored-by: Bindu madhavi tammireddy <41365985+BinduMadhaviTammireddy@users.noreply.github.com> Co-authored-by: Ethan McQuarrie <69437175+EMcQ-BES@users.noreply.github.com> Co-authored-by: Sima-BES <87400368+Sima-BES@users.noreply.github.com>
BinduMadhaviTammireddy
added a commit
that referenced
this pull request
Aug 22, 2021
* 3202: Added 'most_recent' aggregation function to the database (#2904) * 3202: Added most_recent aggregation in database * 3202: Updated postgres docker version for CI/CD * 2731 Changes to Strive map overlay headings (#2886) * 3008: EntityApi class attached to microservices SOL-32 (#2868) * 3008: Added EntityApi - Exported a number of types from entity-server * 3008: Added support for new filter operators in EntityApi * 3008: Wire up report-server to use entityApi * 3008: Fixup bug in /testReport route * MEL-383: Fix flaky reports (#2933) * 2759 map overlay table flippa (#2795) * set up map table component * add map table modal * format table values * wip * select country data * update data formatting * cherry pick table flippa updates * add sort * refactor table flippa to use react table * handle sorting * split up chart table * add table to map components * remove map table from ui components * move react table to ui componnets * add tooltip * move common table components to ui-components * pr suggestions * Update Legend.js * refactor useChartTable * refactor usecharttable * Update StyledTable.js * Add e2e report urls (#2953) * Add sud_district entities to covid-samoa * Add household entity type * Add Covid Samoa households * Update Unknown village entity_relation to un sd * remove set duplicate * covid samoa remove facility overlays * remove household overlay * SOL-281: Added Household Vaccination Status Map Overlay for Covid Samoa (#2950) * SOL-292: Added SubDistrict map overlays for Covid Samoa (#2951) * Use e2e aggregation for the e2e instance (#2954) * Sol 255 create default list of map overlay urls (#2961) Added default.json and fanafana.json for mapoverlays * 3042 Rename one answer option for a question (#2911) * 2843: Remove deprecated analytics api MEL-87 (#2928) * Create larval-habitat entity type (#2976) * Fix participant per 100k overlay (#2975) * Update useDashboardReportData.js (#2962) Co-authored-by: Klaus-S <69126149+Klaus-S@users.noreply.github.com> * Add comment to avoid calculation when checking max length (#2981) * 2910: Flutracking - percent fever & cough per postcode SOL-56 (#2872) * psuh for biao to debug locally - not to merge * commit but do not merge * Update examples.http * Update requestFromTupaiaConfigServer.js * Update requestFromTupaiaConfigServer.js * Update measureData.js * Update index.ts * Update index.ts * Update 20210630053253-AddPostcodePercentFeverOverlayFlutracking-modifies-data.js * Add flu by postcode overlay via reports server * Adjust back to 0 percent min threshold * Update yarn.lock * Update 20210630053253-AddPostcodePercentFeverOverlayFlutracking-modifies-data.js * Update 20210630015116-FlutrackingPostcodeOverlayReportConfig-modifies-data.js * 2729: Add survey period granularity MEL-92 (#2803) * Allow non-5432 db ports (#2820) * Allow non-5432 db ports * Add DB_PORT to .env.example * Add default port to pg-mv-fast-refresh scripts * Add default port to getConnectionConfig * Add configurable port to setupTestDatabase script * Fix survey schema invalidation (#2991) * MEL-390: Admin panel e2e tests scaffolding (#2996) * Move where clause to beginning of select (#3009) * Move where clause to beginning of select * Add unit test * Sol 311 build indicators for pmos (#2983) * SOL-149 delete unwanted facility (#3005) * fix pacmoss indicators (#3012) * MEL-391: Support date range in map overlay urls [e2e] (#2982) * NZ-67 Sync down from KoBo (#2941) * KoBo data service basic setup1 * Add KoBoService to createService file * KoBo API working with hardcoded routes * Migration to add kobo to database service_type enum * Use environment variables in kobo api * Format the response from kobo * Add KoBo translation layer * Add data mapping between kobo and tupaia for FQS1/FQS2 * Filter non mapped data. Keep dataValues in object. * Swap out translate step with template string * Migrations to add sync_cursor table and create kobo sync cursor in it * Add sync cursor to database models * Change kobo submission time option name * Add kobo-api to docker file * Fixup docker file (again) * Add basic unit test so kobo-api has something to run when testing internal dependencies * Change sync_cursor table to sync_service table * Remove redundant service_ from column name * Update sync_time column * NZ-801: Data Service Sync Groups (#2916) * Add migrations for data_service_sync_groups * Add sync group handling to data-broker * Add internal survey code to kobo sync groups * Add data service sync group to models * Swap some functions with arrow functions * Update kobo translator to use sync groups * Allow pulling multiple surveys from KoBo at once * Replace await with return * Point migration to renamed file * PR updates * NZ-793 kobo sync service (#2942) * Add first pass kobo sync * Add KoBo sync creating new survey responses * Reformat string to avoid timezones * Update migration to add answer map Add question mappings for KoBo comment questions * Update migrations to attach answer maps to individual questions * Add answer mapping to kobo translator * Add a check for correct date format in KoBo api * Add option to disable kobo sync * Update error handling for kobo * Add route to trigger manual kobo sync Add better handling for unmapped entities from KoBo * Fixup manual sync * Collapse kobo answer map to one liner * Update kobo manual sync endpoint to accept serviceCode * Update KoBo sync for new table * Add migration for adding laos schools to data_service_entity table * Add data_service_entity to kobo translator layer * Use kobo username as assessor name (if it exists) * Fix copy paste error * Update migration to format date before putting it into db * Rename variable * NZ-823 kobo additional improvements (#2966) * Add db table for sync_service_log Add sync service logs to models Log KoBo skips to sync service log * Update kobo log with record id * Update KoBoApi to fetch data in paginated chunks (#2969) * NZ-826 KoBo unit tests (#2973) * Add KoBoTranslator unit tests * Add unit tests for KoBoService * Add KoBo env variables to meditrak example * Add the last kobo env var that I forgot * Remove redundant return * Remove more redundant returns * Flip the FQS2 answer map Co-authored-by: Klaus-S <69126149+Klaus-S@users.noreply.github.com> * NZ-904: Stop feature instances out of hours (#3020) * Sol-37 connect gaps in data lines (#3013) * Exported FETP survey file is missing numeric only options (#3018) * Update deprecated @babel/polyfill in web-frontend (#3006) * NZ-2: Add migration for 40 target districts (#2988) * Check value of kobo disable var, not just existence (#3035) * Sol 92 pacmossi project card (#3019) * create project card pacmossi * Update 20210816012839-AddProjectPacmossi-modifies-data.js * add second userGroup * Add project details dashboard item to project * Add Tonga to list * update to match dashboard code patterns * entityHierarchyId refactor * Update 20210816012839-AddProjectPacmossi-modifies-data.js * add canonical types * fix canonical_types error * fix sort order * pacmossi-project-card test (#3038) * NZ-2: Add migration for 40 target districts (#2988) * Check value of kobo disable var, not just existence (#3035) Co-authored-by: Ethan McQuarrie <69437175+EMcQ-BES@users.noreply.github.com> Co-authored-by: Bindu madhavi tammireddy <41365985+BinduMadhaviTammireddy@users.noreply.github.com> Co-authored-by: Ethan McQuarrie <69437175+EMcQ-BES@users.noreply.github.com> Co-authored-by: Sima-BES <87400368+Sima-BES@users.noreply.github.com> * SOL-275: Added General and Clinical Dashboards to Nauru eHealth project (#3042) - Cleaned up permissions model for Nauru eHealth * NZ-916: Improve docker container caching ability (#3053) * treat includeRootEntity param in URL as string in entity server (#3059) * SOL-8: Aggregation Chaining in Tupaia Data Api (#2979) * SOL-8: Implemented aggregation chaining in Tupaia Data Api * SOL-8: Added support for background rebuilding of the analytics table - Moved analytics table utility functions to the database - Added ability to force rebuild the analytics table via build_analytics_table(force (default false)) * SOL-8: Bumped pg-mv-fast-refresh version * SOL-8: Updated testDatabaseDump.sql * Disable generating source maps to reduce build size (#3047) * NZ-62 List Visual Type (#2793) * Add migration for ECE target drill down visuals * Remove unused aggregation * PR: Clarify comment Co-authored-by: Edwin Monk-Fromont <edwin.monkfromont@gmail.com> * 2984 Add report for list visual (#2878) * Add indicator configs to ECE drill down migration * Move select after aggregation to fix divide error * Add first pass of list report * Remove unnecessary aggregation * Refactor list visual report to use insert function * PR: Adjust wording of fields * Value as key * Backend fixes for list visual (#2955) * Fix list visual dropping codes from rows * Remove listConfig field from list visual * Add ECE goal drilldowns to dashboard * NZ-62 list visual UI (#2952) * Create ListVisual.js * set up list visual * add list visual to storybook * add list type to lesmis * add working drilldowns * add default circle styles * add button styles * fix loading state * clean up props * update circle * add tooltips to circles * move list visual to ui components * Update VitalsView.js * Delete report.json * add react memos * Update DashboardReportModal.js * move all reports to a single dashboard report modal * fix history * update list modal * move list visual to ui components * add deep link to list visual * nested dashboard items * refactor dashboard modal * tweaks * remove list visual from lesmis * Update useDashboardData.js * add drilldown link as a decorator * Remove all legacy dashboards * Bugfix: Historical data in list visual (#3003) * Show the historical data in the list visual, not just the most recent * Actually the list itself should still be MOST_RECENT * Add Male/Female/GPI lines to lesmis ece list drill downs (#3008) * Add period granularity to list visual Co-authored-by: Edwin Monk-Fromont <edwin.monkfromont@gmail.com> Co-authored-by: Tom Caiger <caigertom@gmail.com> Co-authored-by: Klaus-S <69126149+Klaus-S@users.noreply.github.com> Co-authored-by: Biao Li <31789355+billli0@users.noreply.github.com> Co-authored-by: Rohan Port <59544282+rohan-bes@users.noreply.github.com> Co-authored-by: Kostas Karvounis <kael89@users.noreply.github.com> Co-authored-by: Tom Caiger <caigertom@gmail.com> Co-authored-by: nick <nickw@ourcomunity.com.au> Co-authored-by: Nick Williams <62525113+nick-beyondessential@users.noreply.github.com> Co-authored-by: chris-bes <63621318+chris-bes@users.noreply.github.com> Co-authored-by: Klaus-S <69126149+Klaus-S@users.noreply.github.com> Co-authored-by: Alastair <lockealastair@gmail.com> Co-authored-by: Pauline <pauline@beyondessential.com.au> Co-authored-by: Edwin Monk-Fromont <edwin.monkfromont@gmail.com> Co-authored-by: Ethan McQuarrie <69437175+EMcQ-BES@users.noreply.github.com> Co-authored-by: Andrew <vanbeekandrew@gmail.com> Co-authored-by: Sima-BES <87400368+Sima-BES@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
Changes:
Screenshots: