This repository was archived by the owner on Feb 7, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 660
[fix] Redis connection counter didn't work properly #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #497 +/- ##
=============================================
- Coverage 78.13% 62.01% -16.12%
- Complexity 0 355 +355
=============================================
Files 55 56 +1
Lines 1372 1477 +105
=============================================
- Hits 1072 916 -156
- Misses 300 561 +261
Continue to review full report at Codecov.
|
rennokki
commented
Sep 4, 2020
…avel-websockets into fix/app-connections-count
rennokki
commented
Sep 4, 2020
…avel-websockets into fix/app-connections-count
…avel-websockets into fix/app-connections-count
…ix/app-connections-count
…avel-websockets into fix/app-connections-count
Just managed to turn the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the Redis replicator, each time a new connection is opened or closed, it will increment a value in the database.
Until now, the connection counts were kept in the channel manager and it caused the multi-node deployments to fail to display the right amount of connections and even track them (for example, keeping track the max amount of connections for each app) because the connection counts were hold into each node's memory.
The Redis database will keep a value for the opened connections for each app, instead of letting each server declare the connections number for each app.