Skip to content
This repository was archived by the owner on Feb 7, 2024. It is now read-only.

Fix compatibility with laravel/passport #332

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

ricardo-lobo
Copy link
Contributor

Addresses #331

@irazasyed
Copy link
Contributor

Can we have this merged please? Unable to update this package in L7.

@pawel-marciniak
Copy link

I'm waiting for it too.

@irazasyed
Copy link
Contributor

@freekmurze @mpociot Please merge this?

@dsampaolo
Copy link

Same here. Thank you !

@countnoobula
Copy link

Same here please ❤️

@navaer
Copy link

navaer commented Mar 14, 2020

Need help with this too, there is also error on Laravel 6.18.1 and "laravel/passport": "^8.4".

@backstageel
Copy link

waiting for this to be merged

@kryp7ik
Copy link

kryp7ik commented Mar 18, 2020

I just upgraded to Laravel 7 and was having the same issue however I updated this package to be ^1.4 and also installed nyholm/psr7. After installing nyholm/psr7, Passport is now working without having to upgrade the symfony/psr-http-message-bridge package. Granted I only use Passport in a very limited scope so this may not help for all use cases of Passport. It would be nice for this issue to be resolved so the Symfony package can be updated but just wanted to share my experience in case it helps anyone else.

Edit: I have laravel/passport at version 8.4

@timhaak
Copy link

timhaak commented Mar 25, 2020

Any progress on this pull request?

Just wondering if there is a problem that is preventing a merge.

More asking so that we can possibly help.

@gdebrauwer
Copy link

@freekmurze @mpociot could you have a look at this PR? it's preventing a lot of us from upgrading to Laravel 7

@backstageel
Copy link

For anyone who are having this issue, you could temporarily use this fork:

"repositories": [
    {
      "type": "git",
      "url": "https://github.com/ricardo-lobo/laravel-websockets"
    }
  ],

@ricardo-lobo
Copy link
Contributor Author

For anyone who are having this issue, you could temporarily use this fork:

"repositories": [
    {
      "type": "git",
      "url": "https://github.com/ricardo-lobo/laravel-websockets"
    }
  ],

Thats how I solved! Until this is merged or the issue is fixed.

@shahriar-b
Copy link

24 days already! what are you waiting for?

@mpociot mpociot merged commit d7b9963 into beyondcode:master Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.