This repository was archived by the owner on Feb 7, 2024. It is now read-only.
Fixed channels HTTP API endpoint #127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #149
Currently, we can only get presence channels, because there is a filter in code:
laravel-websockets/src/HttpApi/Controllers/FetchChannelsController.php
Lines 14 to 16 in 1c2b89b
But according to Pusher API documentation, there is no limitations needed, and presence channels should be filtered using
filter_by_prefix=presence-
:https://pusher.com/docs/rest_api#method-get-channels
In this pull request, I implemented correct behavior for this endpoint:
user_count
must be requested viainfo
query param400
will be returned ifuser_count
is requested, and the request is not limited to presence channels