-
Notifications
You must be signed in to change notification settings - Fork 3
update global omp interface #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
bb8ac60
00dc0a3
c20e72e
a51cf21
b2eed9d
ba7e287
b3afdb7
7965aaf
da6aee0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| from . import kduq | ||
| from . import wlh | ||
| from . import chuq | ||
| from . import chuq, kduq, wlh | ||
| from .omp import LocalOpticalPotential, SingleChannelOpticalModel | ||
| from .potential_forms import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
calculate_paramsnow returns(central_params, spin_orbit_params, coulomb_params). This changes the ordering from the earlier Coulomb-first return convention and can break any external code unpackingGlobal.get_params(...)results. Consider preserving the old order or returning a named structure to make ordering explicit and backward-compatible.