Rewrite Text migration guide for 0.15 #1814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bas-ie
approved these changes
Nov 18, 2024
viridia
reviewed
Nov 18, 2024
|
|
||
| __Accessing text spans by index__ | ||
| - `ab_glyph` has been replaced with `cosmic-text`. These changes are mostly internal and the majority of users will not interact with either text backend directly. | ||
| - each text section is now stored as a distinct entity within the standard hierarchy, rather than as a `Vec<TextSection>` on the `Text` component. Children of `Text`/`Text2d` entities with `Text` `Text2d` components will act as additional text sections. |
There was a problem hiding this comment.
Perhaps not a migration issue, but somewhere I think it useful to mention that since text sections are entities, you can now insert components on them, which is useful for things like:
- Dynamically-computed text
- Picking behavior
- Animated text styles.
There was a problem hiding this comment.
Yeah, this belongs in the release notes, not the migration guide.
viridia
reviewed
Nov 18, 2024
rparrett
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Much improved. Couple notes:
There are so many changes to text that I think we could use a few quick before/afters:
- Spawning some text
- Spawning some text with multiple sections
The guide for 15368 also needs adjustment after 15857. It's content would also be better communicated with a diff, I think.
I wonder if we should be linking off to the required components blog post section for context in related migration guides.
MiniaczQ
reviewed
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1782.
This PR leans heavily on the migration guide provide by @MiniaczQ in bevyengine/bevy#15887 <3