Fork Sync

.clang-format

@@ -3,9 +3,11 @@ AllowShortFunctionsOnASingleLine: Inline
 AlwaysBreakTemplateDeclarations: Yes
 BasedOnStyle: LLVM
 BreakConstructorInitializers: BeforeComma
-ColumnLimit: 100
+ColumnLimit: 0
 ConstructorInitializerAllOnOneLineOrOnePerLine: true
 IndentWidth: 4
+IndentAccessModifiers: false
+AccessModifierOffset: -4
 PointerAlignment: Left
 IncludeCategories:
   - Regex:           '^"\.\./'

.clang-tidy

@@ -1,7 +1,21 @@
 ---
-Checks:          'clang-diagnostic-*,clang-analyzer-*,modernize-*,portability-*,llvm-*,-llvm-include-order,-modernize-use-nodiscard,-llvm-header-guard'
-WarningsAsErrors: 'clang-diagnostic-*,clang-analyzer-*,portability-*,llvm-*'
-HeaderFilterRegex: 'TrustWallet|^src|^./src'
+Checks: >
+    clang-diagnostic-*,
+    clang-analyzer-*,
+    modernize-*,
+    portability-*,
+    llvm-*,
+    -clang-analyzer-core.uninitialized.Assign,
+    -llvm-include-order,
+    -llvm-header-guard,
+    -llvm-else-after-return,
+    -modernize-use-using,
+    -modernize-use-nodiscard,
+    -modernize-use-trailing-return-type,
+    -modernize-deprecated-headers,
+    -modernize-avoid-c-arrays
+WarningsAsErrors: false
+HeaderFilterRegex: '^src|^./src'
 AnalyzeTemporaryDtors: false
 FormatStyle:     none
 InheritParentConfig: false

.devcontainer/Dockerfile

@@ -0,0 +1,73 @@
+FROM mcr.microsoft.com/devcontainers/base:ubuntu-22.04
+
+ENV DEBIAN_FRONTEND=noninteractive
+
+# Install some basics
+RUN apt-get update \
+    && apt-get install -y \
+        wget \
+        curl \
+        git \
+        vim \
+        unzip \
+        xz-utils \
+        software-properties-common \
+    && apt-get clean && rm -rf /var/lib/apt/lists/*
+
+# Add latest cmake
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN wget -O - https://apt.kitware.com/keys/kitware-archive-latest.asc | apt-key add - \
+    && apt-add-repository "deb https://apt.kitware.com/ubuntu/ $(lsb_release -sc) main"
+
+# Install required packages for dev
+RUN apt-get update \
+    && apt-get install -y \
+        build-essential \
+        libtool autoconf pkg-config \
+        ninja-build \
+        ruby-full \
+        clang-14 \
+        llvm-14 \
+        libc++-dev libc++abi-dev \
+        cmake \
+        libboost-all-dev \
+        ccache \
+        # Swift dependencies
+        binutils \
+        git \
+        gnupg2 \
+        libc6-dev \
+        libcurl4-openssl-dev \
+        libedit2 \
+        libgcc-9-dev \
+        libpython3.8 \
+        libsqlite3-0 \
+        libstdc++-9-dev \
+        libxml2-dev \
+        libz3-dev \
+        pkg-config \
+        tzdata \
+        unzip \
+        zlib1g-dev \
+    && apt-get clean && rm -rf /var/lib/apt/lists/*
+
+ENV CC=/usr/bin/clang-14
+ENV CXX=/usr/bin/clang++-14
+
+# Instal Swift
+RUN curl -sSL \
+	https://download.swift.org/swift-5.8-release/ubuntu2204/swift-5.8-RELEASE/swift-5.8-RELEASE-ubuntu22.04.tar.gz \
+	-o swift-5.8.tar.gz && \
+    mkdir -p swift-5.8 && \
+    tar -xzf swift-5.8.tar.gz -C swift-5.8 --strip-components=1 && \
+    mv swift-5.8 /usr/share/swift
+
+ENV PATH="/usr/share/swift/usr/bin:${PATH}"
+
+USER vscode
+
+# Install rust
+RUN curl https://sh.rustup.rs -sSf | sh -s -- --no-modify-path -y
+ENV PATH="/home/vscode/.cargo/bin:${PATH}"
+RUN cargo install --force cbindgen \
+    && rustup target add wasm32-unknown-emscripten

.devcontainer/devcontainer.json

@@ -0,0 +1,31 @@
+// For format details, see https://aka.ms/devcontainer.json. For config options, see the
+// README at: https://github.com/devcontainers/templates/tree/main/src/debian
+{
+	"name": "Debian",
+	// Use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
+	"build": {
+		"dockerfile": "Dockerfile"
+	},
+
+	// Features to add to the dev container. More info: https://containers.dev/features.
+	// "features": {},
+
+	// Use 'forwardPorts' to make a list of ports inside the container available locally.
+	// "forwardPorts": [],
+
+	// Configure tool-specific properties.
+	"customizations": {
+		"vscode": {
+			"extensions": [
+				"rust-lang.rust-analyzer",
+				"sswg.swift-lang",
+				"ms-vscode.cpptools",
+				"ms-vscode.cpptools-extension-pack",
+				"rebornix.Ruby"
+			]
+		}
+	},
+
+	// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
+	"remoteUser": "vscode"
+}

.dockerignore

@@ -0,0 +1 @@
+.gitignore

.github/CODEOWNERS

@@ -3,4 +3,5 @@
 # @global-owner1 and @global-owner2 will be requested for
 # review when someone opens a pull request.
 
-* @hewigovens @catenocrypt
+* @satoshiotomakan @gupnik
+kotlin/ @JaimeToca @rkokhatskyi

.github/ISSUE_TEMPLATE/feature_request.md

@@ -16,5 +16,23 @@ A clear and concise description of what you want to happen.
 **Describe alternatives you've considered**
 A clear and concise description of any alternative solutions or features you've considered.
 
+**Checklist**
+
+<!--- Group checklist per issue needed, one specific feature of your goal -->
+<!--- Each big task can have subtask, doesn't hesitate to split into small pull request to simplify the review process -->
+
+- [ ] task number 1
+    - [ ] subtask number 1
+    - [ ] subtask number 2
+- [ ] task number 2
+- [ ] task number 3
+
+**Resources**
+
+<!--- Link resources this way: [My Resource Title](link) -->
+
+Resources link
+
 **Additional context**
+
 Add any other context or screenshots about the feature request here.

.github/PULL_REQUEST_TEMPLATE.md

@@ -2,7 +2,7 @@
 
 <!--- Describe your changes in detail -->
 
-## Testing instructions
+## How to test
 
 <!--- Please describe how reviewers can test your changes -->
 
@@ -20,8 +20,11 @@
 
 <!--- The following points should be used to indicate the progress of your PR.  Put an `x` in all the boxes that apply right now, and come back over time and check them off as you make progress.  If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
 
-- [ ] Prefix PR title with `[WIP]` if necessary.
+- [ ] Create pull request as draft initially, unless its complete.
 - [ ] Add tests to cover changes as needed.
 - [ ] Update documentation as needed.
-- [ ] I have read the [guidelines](https://developer.trustwallet.com/wallet-core/newblockchain#integration-criteria) for adding a new blockchain
-- [ ] If there is a related Issue, mention it in the description (e.g. Fixes #<issue_number> ).
+- [ ] If there is a related Issue, mention it in the description.
+
+If you're adding a new blockchain
+
+- [ ] I have read the [guidelines](https://developer.trustwallet.com/wallet-core/newblockchain#integration-criteria) for adding a new blockchain.

.github/workflows/android-ci.yml

@@ -2,39 +2,84 @@ name: Android CI
 
 on:
   push:
-    branches: [ master ]
+    branches: [ dev, master ]
   pull_request:
-    branches: [ master ]
+    branches: [ dev, master ]
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
 
 jobs:
   build:
+    runs-on: macos-latest-large
+    if: github.event.pull_request.draft == false
+    steps:
+    - uses: actions/checkout@v3
+
+    - name: Set up JDK 17
+      uses: actions/setup-java@v3
+      with:
+        java-version: '17'
+        distribution: 'temurin'
 
-    runs-on: macos-10.15
+    - name: Setup Gradle
+      uses: gradle/gradle-build-action@v2
+      with:
+        gradle-version: 8.10.2
 
-    steps:
-    - uses: actions/checkout@v2
     - name: Install system dependencies
-      run: brew install boost ninja
-    - name: Install Android Dependencies
       run: |
-        $ANDROID_HOME/tools/bin/sdkmanager --verbose "cmake;3.10.2.4988404" "ndk;21.2.6472646"
-        $ANDROID_HOME/tools/bin/sdkmanager "system-images;android-26;google_apis;x86"
-    - name: Accept Licenses
-      run: echo -e "y\ny\ny\ny\ny\n" | $ANDROID_HOME/tools/bin/sdkmanager --licenses
+        tools/install-sys-dependencies-mac
+
+    - name: Cache Rust
+      uses: Swatinem/rust-cache@v2
+      with:
+        workspaces: |
+          rust
+
+    - name: Install Rust dependencies
+      run: |
+        tools/install-rust-dependencies
+
+    - name: Install Android Dependencies
+      run: tools/install-android-dependencies
+
     - name: Cache internal dependencies
       id: internal_cache
-      uses: actions/cache@v1.1.2
+      uses: actions/cache@v3
       with:
         path: build/local
-        key: ${{ runner.os }}-internal-${{ hashFiles('tools/install-dependencies') }}
+        key: ${{ runner.os }}-${{ runner.arch }}-internal-${{ hashFiles('tools/install-dependencies') }}-${{ hashFiles('tools/dependencies-version') }}
+
     - name: Install internal dependencies
-      run: |
-        tools/install-dependencies
+      run: tools/install-dependencies
       if: steps.internal_cache.outputs.cache-hit != 'true'
-    - name: Run test
+
+    - name: Generate files
+      run: tools/generate-files android
+
+    - name: Build Kotlin doc
+      run: tools/kotlin-doc
+
+    - name: Build tests
       run: |
-        tools/generate-files
-        tools/android-test
+        pushd android
+        ./gradlew assembleAndroidTest
+        popd
+
+    - name: Run tests
+      uses: reactivecircus/android-emulator-runner@v2
+      with:
+        api-level: 30
+        target: google_apis
+        arch: x86
+        ndk: 23.1.7779620
+        cmake: 3.18.1
+        script: cd android; ./gradlew connectedAndroidTest
+
     - name: Build sample app
-      run: |
-        tools/samples-build android
+      run: tools/samples-build android
+      env:
+        GITHUB_USER: ${{ github.actor }}
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/codegen-v2.yml

@@ -0,0 +1,47 @@
+name: Codegen-v2 Tests
+
+on:
+  push:
+    branches: [ dev, master ]
+  pull_request:
+    branches: [ dev, master ]
+
+env:
+  SCCACHE_GHA_ENABLED: "true"
+  RUSTC_WRAPPER: "sccache"
+
+jobs:
+  test:
+    runs-on: ubuntu-24.04
+    if: github.event.pull_request.draft == false
+    steps:
+      - uses: actions/checkout@v3
+      - name: Install system dependencies
+        run: |
+          tools/install-sys-dependencies-linux
+
+      - name: Run sccache-cache
+        uses: mozilla-actions/sccache-action@v0.0.8
+
+      - name: Install Rust dependencies
+        run: |
+          tools/install-rust-dependencies
+
+      - name: Run codegen-v2 tests
+        run: |
+          cargo test --all
+        working-directory: codegen-v2
+
+      # Generate files for a blockchain.
+      # Please note the blockchain should not be implemented in Rust at the moment of running this step,
+      # otherwise consider either generating files for another blockchain or removing this step at all.
+      - name: Test codegen-v2 new-blockchain-rust
+        run: |
+          cargo run -- new-blockchain-rust iotex
+        working-directory: codegen-v2
+
+      # Check if `new-blockchain-rust` command has generated files that do not break project compilation.
+      - name: Check Rust compiles
+        run: |
+          cargo check --tests
+        working-directory: rust