Skip to content

APEXF7 - add gyro 2 ICM20602 #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nerdCopter
Copy link
Member

@nerdCopter nerdCopter commented Jun 22, 2025

  • Original APEXF7 had optional second gyro.
  • The PINS were already assigned, but the ACC/GYRO was not defined.
    2025-06-22_11-03
    2025-06-22_11-14
    2025-06-22_11-13
    image

- Original APEXF7 had optional second gyro.
- The PINS were already assigned, but the ACC/GYRO was not defined.
Copy link

coderabbitai bot commented Jun 22, 2025

Walkthrough

Two preprocessor macros were added to the APEXF7 board configuration header to enable SPI support for the ICM20602 accelerometer and gyroscope sensors. No other files or functionalities were changed.

Changes

File Change Summary
configs/APEXF7/config.h Added macros to enable SPI ICM20602 sensor support for accelerometer and gyroscope

Sequence Diagram(s)

No sequence diagram generated as the changes are limited to macro definitions and do not affect control flow.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 96eebb9 and 8ef7bd4.

📒 Files selected for processing (1)
  • configs/APEXF7/config.h (1 hunks)
🔇 Additional comments (2)
configs/APEXF7/config.h (2)

31-31: Confirm accelerometer driver selection
Defining both USE_ACC_SPI_MPU6000 and USE_ACC_SPI_ICM20602 will compile two ACC drivers, which can conflict since only one accelerometer instance is supported. Please verify the intended sensor mapping—either replace the primary ACC driver or introduce distinct ACC2 support—and update the macros or driver logic accordingly.


34-34: Second gyro driver enabled correctly
The addition of USE_GYRO_SPI_ICM20602 matches the shared SPI3 bus and separate CS pin setup for the second gyro. This aligns with the board’s hardware assignment.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or `` to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants