Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved issue of compas (mag_adc[]) curves #787

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

demvlad
Copy link
Contributor

@demvlad demvlad commented Nov 1, 2024

Resolved issue of empty string value at compas (mag_adc[]) curves legend:
-added friendly legends caption for fields
-added data transform for curves Min-Max values
To prevent similar issue for other unknown fields, the default friendly legends caption is changed from empty string to raw fields value.

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for origin-blackbox-logviewer ready!

Name Link
🔨 Latest commit 2a4ae46
🔍 Latest deploy log https://app.netlify.com/sites/origin-blackbox-logviewer/deploys/6724ed3bf8d4bc0008de6496
😎 Deploy Preview https://deploy-preview-787.dev.blackbox.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

sonarqubecloud bot commented Nov 1, 2024

@nerdCopter
Copy link
Member

please screenshot before/after (or errored console if applicable)

@demvlad
Copy link
Contributor Author

demvlad commented Nov 1, 2024

please screenshot before/after (or errored console if applicable)

@nerdCopter
Yes, of course:
Test file:
compas_test.txt

The master branch
CompasMaster
This PR
CompasAfter

To prevent this issue for other fields, what have not friendly values transform, the default value is changed in 2nd commit. The raw value is better than nothing.

@haslinghuis haslinghuis added this to the 4.0.0 milestone Nov 1, 2024
@haslinghuis haslinghuis merged commit 0020595 into betaflight:master Nov 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants