Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump NWjs to 0.54.1 #523

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Aug 2, 2021

To keep in sync with betaflight/betaflight-configurator#2548

Bumped the ffmpeg libraries to 0.55.0 as the prebuilt libraries are not available for 0.54.1 and 0.54.0 is incomplete.

@asizon
Copy link
Member

asizon commented Aug 3, 2021

@haslinghuis Ffmpeg also need to be update to a compatible 0.55 version,and try if all video conversions works.

@asizon
Copy link
Member

asizon commented Aug 3, 2021

Take it as reference #487

@haslinghuis
Copy link
Member Author

The ffmpeg prebuilt library for 0.55.0 is not available yet.

@McGiverGim
Copy link
Member

Sometimes the latest version is compatible with the current version, and for this reason he does not release a new version of the library.
What I want to say is that maybe library 0.54 works for nw 0.55.

@haslinghuis haslinghuis changed the title Bump NWjs to 0.55.0 Bump NWjs to 0.54.1 Aug 4, 2021
@haslinghuis
Copy link
Member Author

haslinghuis commented Aug 5, 2021

Update: there is a new release covering both 0.54.0 and 0.55.0 but not 0.54.1 and the 0.54.0 version has no linux libraries.
https://github.com/iteufel/nwjs-ffmpeg-prebuilt/releases

Created an issue here for 0.54.x nwjs-ffmpeg-prebuilt/nwjs-ffmpeg-prebuilt#116 which does not have a linux library.

There was a problem with an user letting me downgrade 0.55.0 to 0.54.1 as this is working on Apple while maintaining the Notification Center icons as mentioned here: betaflight/betaflight-configurator#2274

@haslinghuis
Copy link
Member Author

Updating with nwjs-ffmpeg-prebuilt 0.55.0 seems to work.

McGiverGim
McGiverGim previously approved these changes Aug 6, 2021
@haslinghuis
Copy link
Member Author

Rebased

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@blckmn
Copy link
Member

blckmn commented Oct 29, 2021

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit 574cb42 into betaflight:master Oct 29, 2021
@haslinghuis haslinghuis deleted the update_nwjs branch October 29, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants