Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Dterm Rpm and Vbat Pid Compensation header options from 4.3 #459

Merged
merged 3 commits into from
Jul 27, 2020
Merged

Removed Dterm Rpm and Vbat Pid Compensation header options from 4.3 #459

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56f4857
Removed Dterm Rpm and PidCompensation from 4.3
asizon Jul 26, 2020
cfd2b2b
Fix max version supported
asizon Jul 26, 2020
4069899
Allow versions higher than 4.2.10
asizon Jul 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions js/header_dialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ function HeaderDialog(dialog, onSave) {
{name:'airmode_activate_throttle' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'2.8.0', max:'999.9.9'},
{name:'rollPitchItermIgnoreRate' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'2.8.0', max:'3.0.1'},
{name:'yawItermIgnoreRate' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'2.8.0', max:'3.0.1'},
{name:'vbat_pid_compensation' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'2.8.0', max:'4.2.0'},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imho it should be 4.2.9 - to include maintenance releases as well

Copy link
Member Author

@asizon asizon Jul 26, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @thelsotopes , thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Or even 4.2.999 to follow the pattern that is used.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad idea ... the pattern is 999.9.9 not 999.9.999

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, 999 is used only for the first number, done!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is broken now - it will fail for 4.2.10 and following. Please learn how to use SemVer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes right @mikeller, then im going to use 999 like you suggested

{name:'gyro_notch_hz' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'3.0.0', max:'999.9.9'},
{name:'gyro_notch_cutoff' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'3.0.0', max:'999.9.9'},
{name:'dterm_lpf2_hz' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'3.4.0', max:'999.9.9'},
Expand Down Expand Up @@ -83,9 +84,9 @@ function HeaderDialog(dialog, onSave) {
{name:'gyro_rpm_notch_harmonics' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.1.0', max:'999.9.9'},
{name:'gyro_rpm_notch_q' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.1.0', max:'999.9.9'},
{name:'gyro_rpm_notch_min' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.1.0', max:'999.9.9'},
{name:'dterm_rpm_notch_harmonics' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.1.0', max:'999.9.9'},
{name:'dterm_rpm_notch_q' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.1.0', max:'999.9.9'},
{name:'dterm_rpm_notch_min' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.1.0', max:'999.9.9'},
{name:'dterm_rpm_notch_harmonics' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.1.0', max:'4.2.0'},
{name:'dterm_rpm_notch_q' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.1.0', max:'4.2.0'},
{name:'dterm_rpm_notch_min' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.1.0', max:'4.2.0'},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same for these three

{name:'dshot_bidir' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.1.0', max:'999.9.9'},
{name:'iterm_relax' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.1.0', max:'999.9.9'},
{name:'iterm_relax_type' , type:FIRMWARE_TYPE_BETAFLIGHT, min:'4.1.0', max:'999.9.9'},
Expand Down