Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember position and size of the window #453

Merged
merged 1 commit into from
Jul 12, 2020

Conversation

McGiverGim
Copy link
Member

Fixes #377

Remembers the window size and position. At least for the first window. If you open more than one only the first is respected. I think is enough.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mikeller
Copy link
Member

mikeller commented Jul 7, 2020

One concern that I have is that this will obviously lead to ever-increasing metadata for the app, as every time a new window is opened a new entry for its id is created. But I think this is pretty much cosmetical.

@mikeller mikeller added this to the 3.6.0 milestone Jul 7, 2020
@McGiverGim
Copy link
Member Author

I suppose you are talking about when creating "others" windows. This change will add a constant id for the main window, but when opening more than one I suppose that yes, this others will create a random id.
Do you know where this metadata is stored?

@mikeller
Copy link
Member

mikeller commented Jul 7, 2020

Wait, I'd misread that. Been a long day ;-)

@McGiverGim
Copy link
Member Author

Not at all. I think your concerns have sense when opening more than one window. If I have time I will do some tests to see the behavior but it will be for another PR.

@mikeller mikeller merged commit 0c2820f into betaflight:master Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maximized window is not saved
2 participants