Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Expo, Smooth and Grid by default #448

Merged
merged 1 commit into from
Jun 21, 2020

Conversation

McGiverGim
Copy link
Member

Fixes #447

This PR makes Expo, Smooth and Grid disabled by default.

This only happens ON NEW installations, because when updating the user has the state stored from earlier versions (by default or the value he wants).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@0crap
Copy link

0crap commented Jun 19, 2020

Great, thx!

On a old installation, how can I set the new defaults?
Just do an export workspaces, uninstall viewer, reinstall viewer, import the saved workspaces .json file?

@McGiverGim
Copy link
Member Author

No, each graph has a default expo and smooth applied, but you have the lower right icons in the UI to ignore this values. If you disable this icons no expo or smoothing is applied.
What this PR does is to disable this icons on new installations.

@mikeller mikeller added this to the 3.6.0 milestone Jun 21, 2020
@mikeller mikeller merged commit 4f6f920 into betaflight:master Jun 21, 2020
@0crap
Copy link

0crap commented Jun 21, 2020

@McGiverGim I just installed the latest BB log viewer nightly build on top of my existing Windows installation. Guess what.... I see now Expo/Smoothing/Grid is automagically switched to Off.
So your PR also seems to work for old upgraded Windows installations.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More useful default settings
3 participants