Added Frequency vs Throttle Spectrum Graph #322
Conversation
js/graph_spectrum.js
Outdated
| ANALYSER_LARGE_LEFT_MARGIN = 10, | ||
| ANALYSER_LARGE_TOP_MARGIN = 10, | ||
| ANALYSER_LARGE_HEIGHT_MARGIN = 20, | ||
| ANALYSER_LARGE_WIDTH_MARGIN = 20; | ||
| ANALYSER_LARGE_WIDTH_MARGIN = 20, | ||
| FIELD_THROTTLE_NAME ='rcCommands[3]', |
| _fftData : null, | ||
| _mouseFrequency : null, | ||
| _sysConfig : null, | ||
| _isFullScreen : false, |
There was a problem hiding this comment.
This is a good example of why I am generally not in favour of aligning code - reviewing this is made harder by the fact that it had to be realigned...
There was a problem hiding this comment.
Yes, I try to not do it, I understood the reasons the latest time, but I do it without thinking (at my real job we don't make revisions). 😁
McGiverGim
force-pushed
the
refactor_spectrum
branch
from
c337785 to
a2d3fd0
Compare
|
Left of BBE 3.3.0 and right is with the above PR. Spectrum of Debug values is showing different.
Throttle based waterfall seems fine though. Look like spectrum is mirroring plot.
|
|
Thanks for testing it @spatzengr !! I saw something similar yesterday, but it seemed to me that the old version shown it too. Is clear that not. I will try to fix it. |
|
The problem was not with this PR. It was produced in other before. I have pushed a PR to fix it, but I'm not sure if it will work in all cases. Do not merge this until the other PR is merged, and I will see if this needs some changes. @spatzengr if you can test the other PR (#323) to see if all is ok with this, with different blackbox files with different blackbox rates it will be great. |
McGiverGim
force-pushed
the
refactor_spectrum
branch
from
a2d3fd0 to
f9fba61
Compare
|
@mikeller rebased against master. Ready to be merged ;) |
This PR continues the serie of PR about the Spectrum Graph that we let here: #316
This PR adds the possibility to show the Frequency vs Throttle in the Spectrum graph:
The sliders in the maximized version move the frequency and the intensity of the heat scale.
I cached all that I could but some things are slow. I will try to optimize it in future PR if I find a way.
My math skills are very limited, so thanks to @bw1129 the author of PidToolBox for point me in the right direction.
I'm pretty sure there are things that can be done better, I imitated the way it was done in the standard frequency spectrum, so if someone with better knowledge of maths want to take a look, there are some things that I'm not sure why are done in this way, specially related with the size of the arrays passed to the FFT.
I think that the future PR can be:
spectrum_graph.jsfile and divide it into two, one for control and the other for the calcs.