Show MSP API version in cli #4124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeller
reviewed
Sep 11, 2017
| @@ -36,3 +36,5 @@ extern const char* const buildDate; // "MMM DD YYYY" MMM = Jan/Feb/... | |||
|
|
|||
| #define BUILD_TIME_LENGTH 8 | |||
| extern const char* const buildTime; // "HH:MM:SS" | |||
|
|
|||
| #define MSP_API_VERSION_STRING STR(API_VERSION_MAJOR) "." STR(API_VERSION_MINOR) | |||
There was a problem hiding this comment.
Maybe add something like MSP API: to the string to make it explicit what the number is.
There was a problem hiding this comment.
Could you elaborate? API_VERSION_MAJOR and API_VERSION_MINOR are already defined in msp/msp_protocol.h. This is just referencing those variables. Should I rename those variables everywhere?
mikeller
reviewed
Sep 11, 2017
src/main/fc/cli.c
Outdated
| @@ -3079,14 +3081,15 @@ static void cliVersion(char *cmdline) | |||
| { | |||
| UNUSED(cmdline); | |||
|
|
|||
| cliPrintLinef("# %s / %s (%s) %s %s / %s (%s)", | |||
| cliPrintLinef("# %s / %s (%s) %s %s / %s (%s) %s", | |||
There was a problem hiding this comment.
Sorry, I attached my previous comment to the wrong line, it should really have gone here.
There was a problem hiding this comment.
Done, rebased and squashed. It now looks like:
# version
# Betaflight / SPRACINGF3 (SRF3) 3.2.0 Sep 10 2017 / 22:09:06 (c73ad66b0) MSP API: 1.36
mikeller
approved these changes
Sep 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows the MSP api version in the cli under
version. In this case1.36