Fix duplicate ID

[haslinghuis]

Summary by CodeRabbit

• Refactor
  • Updated element identifiers in the EscDshotDirection component for improved clarity and differentiation within dialogs. No visible changes to functionality or layout.

[coderabbitai]

Walkthrough

The changes update the id attributes of two <h4> elements within the EscDshotDirection component's HTML template, assigning unique identifiers to distinguish between the "NormalDialog" and "WizardDialog" sections. No other structural, functional, or exported entity changes are introduced.

Changes

File	Change Summary
src/components/EscDshotDirection/Body.html	Renamed id attributes of two <h4> elements for unique section IDs

Sequence Diagram(s)

No sequence diagram generated as the changes are limited to HTML attribute renaming without affecting control flow or component interactions.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ff56c4 and fbabe8e.

📒 Files selected for processing (1)

• src/components/EscDshotDirection/Body.html (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build

🔇 Additional comments (2)

src/components/EscDshotDirection/Body.html (2)

24-24:

✅ Verification successful

IDs for auto-save messages are now distinct per dialog.

Renamed the <h4> ID to escDshotDirectionDialog-SettingsAutoSaved-Normal to avoid duplicate IDs in the NormalDialog section. Ensure that any JS/CSS selectors or event handlers targeting the old escDshotDirectionDialog-SettingsAutoSaved ID have been updated to the new one.

---

🏁 Script executed:

#!/bin/bash
# Verify no lingering references to the old SettingsAutoSaved ID
grep -R 'escDshotDirectionDialog-SettingsAutoSaved"' -n src/

Length of output: 412

---

No lingering references to the old escDshotDirectionDialog-SettingsAutoSaved ID

Verified that only the new IDs with -Normal (line 24) and -Wizard (line 35) suffixes exist in src/components/EscDshotDirection/Body.html. No JS/CSS selectors or event handlers target the old escDshotDirectionDialog-SettingsAutoSaved ID.

---

35-35:

✅ Verification successful

IDs for auto-save messages are now distinct per dialog.

Renamed the <h4> ID to escDshotDirectionDialog-SettingsAutoSaved-Wizard to avoid duplicate IDs in the WizardDialog section. Confirm that all references—including test fixtures, stylesheets, or scripts—have been updated accordingly.

---

🏁 Script executed:

#!/bin/bash
# Verify no lingering references to the old SettingsAutoSaved ID
grep -R 'escDshotDirectionDialog-SettingsAutoSaved"' -n src/

Length of output: 412

---

🏁 Script executed:

#!/bin/bash
# Verify no lingering references to the old auto-save ID attribute
grep -R 'id="escDshotDirectionDialog-SettingsAutoSaved"' -n src/

# Search the entire repo for any occurrences of the SettingsAutoSaved key
grep -R 'SettingsAutoSaved' -n .

Length of output: 1200

---

No remaining references to old auto-save ID

A repo-wide search for escDshotDirectionDialog-SettingsAutoSaved only returned the two updated <h4> IDs in src/components/EscDshotDirection/Body.html and the corresponding translation keys in locales/*.json (as expected). No lingering references—in tests, styles, or scripts—were found.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Preview URL: https://fbabe8ec.betaflight-configurator.pages.dev