Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix port picker trigger event #3781

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

haslinghuis
Copy link
Member

Port picker change event was not triggered upon changing flight controller. As a consequence updateManualPortVisibility was not triggered to update the connection area.

image

@haslinghuis haslinghuis added this to the 10.10.0 milestone Feb 3, 2024
@haslinghuis haslinghuis self-assigned this Feb 3, 2024
Copy link

sonarqubecloud bot commented Feb 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Feb 3, 2024

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

Copy link
Member

@HThuren HThuren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, I did have trouble when switching between ex. COM and virtuel, now seems to disapear.

@haslinghuis haslinghuis merged commit 72429eb into betaflight:master Feb 4, 2024
7 checks passed
@haslinghuis haslinghuis deleted the fix-port-picker-trigger branch February 4, 2024 11:00
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

3 participants