Fix: maps and dist/dist/dist builds
#3682
Conversation
|
|
Do you want to test this code? Here you have an automated build: |
|
AUTOMERGE: (FAIL)
|
| @@ -124,7 +124,7 @@ gulp.task('apps', appsBuild); | |||
| const debugAppsBuild = gulp.series(gulp.parallel(clean_debug, gulp.series(clean_dist, debugDistBuild)), debug, gulp.series(cordova_apps(false)), gulp.parallel(listPostBuildTasks(DEBUG_DIR))); | |||
|
|
|||
| const debugBuildNoStart = gulp.series(debugDistBuild, debug, gulp.parallel(listPostBuildTasks(DEBUG_DIR))); | |||
| const debugBuild = gulp.series(debugBuildNoStart, start_debug); | |||
| const debugBuild = gulp.series(clean_dist, debugBuildNoStart, start_debug); | |||
There was a problem hiding this comment.
The clean_dist was removed from the debug build to accelerate the build while testing. There isn't a better fix?
There was a problem hiding this comment.
This step takes only one or two seconds on my system.
There was a problem hiding this comment.
i don't mind cleaning as well. my alias command does this manually, nice to return, imho.
There was a problem hiding this comment.
We can do any optimization after we fix this bug.
There was a problem hiding this comment.
The problem is not the clean_dist command, at least before the change, the rest of the debugBuild was a lot faster if the files were there and a lot slower if it must start from scratch. I don't know if this applies to the current version, the build has changed a lot since then.
There was a problem hiding this comment.
yarn && yarn start the second times takes about 10 seconds here.
There was a problem hiding this comment.
that's fair too. i;ve not seen problems, since i always force a clean. this line can be reverted if desired.
There was a problem hiding this comment.
Then we get the repeating dist dist dist issue
|
@chmelevskij - I'd be really grateful if you could possibly make a PR that would enable the 'satellite' or 'terrain' view of the map - is that possible? |
* fix: load in `map.js` * fix: clean dist before build
dist/dist/dist/distbuild bugmap.jsfor gps tab to work as expectedResolves #3681