Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix virtual disconnect #3620

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Fix virtual disconnect #3620

merged 1 commit into from
Nov 1, 2023

Conversation

haslinghuis
Copy link
Member

No description provided.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Oct 30, 2023
@haslinghuis haslinghuis self-assigned this Oct 30, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Oct 31, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@nerdCopter
Copy link
Member

How to test this? Just virtual-connect with save/reboot? or some other method?

@haslinghuis
Copy link
Member Author

@nerdCopter It was not possible to disconnect from virtual connection.

@haslinghuis haslinghuis merged commit feb5a48 into betaflight:master Nov 1, 2023
8 checks passed
@haslinghuis haslinghuis deleted the fix-virtual-disconnect branch November 1, 2023 16:27
@HThuren
Copy link
Member

HThuren commented Nov 1, 2023

@haslinghuis great catch, I working on a PR with more virtuel data, and this is a great improvement :-)

chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Fix virtual disconnect (betaflight#3620)
c4a4e2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmelevskij chmelevskij chmelevskij approved these changes

@blckmn blckmn blckmn approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@haslinghuis @blckmn @nerdCopter @HThuren @chmelevskij