Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tooltip #3175

Merged
merged 1 commit into from
Dec 30, 2022
Merged

Fix tooltip #3175

merged 1 commit into from
Dec 30, 2022

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Dec 27, 2022 •
edited
Loading

Fixes: #3162
Fixes: #3169

@haslinghuis haslinghuis added this to the 10.9.0 milestone Dec 27, 2022
@haslinghuis haslinghuis self-assigned this Dec 27, 2022
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Dec 27, 2022 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

McGiverGim
McGiverGim approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are giving too much work to the translators ;) this changes are more for a beta version than for a RC :P

@haslinghuis
Copy link
Member Author

Yes agree - Crowdin should be smart here (as we are just removing a sentence from already translated message).

Also need to address #3162

@McGiverGim
Copy link
Member

Yes agree - Crowdin should be smart here (as we are just removing a sentence from already translated message)

Yes, it is, but needs the proofreader intervention. It will invalidate the older translations, and suggest the new, but the proofreader needs to enter and approve it.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haslinghuis
Copy link
Member Author

Really need help with the WIKI button as it does not work like other tabs (while using main.less css)

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit b287361 into betaflight:master Dec 30, 2022
@haslinghuis haslinghuis deleted the fix-tooltip branch December 30, 2022 23:32
@hydra hydra mentioned this pull request Jan 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@sugaarK sugaarK sugaarK approved these changes

@blckmn blckmn Awaiting requested review from blckmn

Assignees

@haslinghuis haslinghuis

Labels
RN: UI
Projects
None yet
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.

Cloud build tooltip doesn't match UI behaviour. Target tooltip documentation requires updating.
4 participants
@haslinghuis @blckmn @McGiverGim @sugaarK