Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fields for PID and rate profile names. #3150

Merged
merged 3 commits into from
Dec 17, 2022
Merged

Fields for PID and rate profile names. #3150

merged 3 commits into from
Dec 17, 2022

Conversation

qvasic
Copy link
Contributor

@qvasic qvasic commented Dec 16, 2022 •
edited
Loading

Fixes #3064

Some pilots have different PID profiles for different payloads/conditions they fly(lighter/bigger battery, action camera/no camera, various elevations), different rate profiles for different styles of flying (cine, race, freestyle).
Having readable profile names would significantly simplify selecting the proper profile, as opposed to memorizing profile numbers - just imagine having N quads with M profiles each.

image

image

@qvasic qvasic marked this pull request as draft December 16, 2022 17:07
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis mentioned this pull request Dec 16, 2022
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haslinghuis haslinghuis added this to the 10.9.0 milestone Dec 16, 2022
@qvasic qvasic marked this pull request as ready for review December 16, 2022 23:40
@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Dec 17, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@KarateBrot KarateBrot merged commit bc6307a into betaflight:master Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@KarateBrot KarateBrot KarateBrot approved these changes

@sugaarK sugaarK Awaiting requested review from sugaarK

Assignees

@qvasic qvasic

Labels
RN: BUGFIX RN: IMPROVEMENT Tested
Projects
None yet
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.

PID Profile Names
4 participants
@qvasic @blckmn @haslinghuis @KarateBrot