Fix VTX status update after saving #3034

haslinghuis · 2022-10-06T21:26:54Z

blckmn · 2022-10-06T23:17:05Z

AUTOMERGE: (FAIL)

github identifies PR as mergeable -> FAIL
assigned to a milestone -> PASS
cooling off period lapsed -> PASS
commit count less or equal to three -> PASS
Don't merge label NOT found -> PASS
at least one RN: label found -> PASS
Tested label found -> FAIL
assigned to an approver -> PASS
approver count at least three -> FAIL

McGiverGim · 2022-10-07T11:22:45Z

src/js/tabs/vtx.js

@@ -891,7 +891,7 @@ vtx.initialize = function (callback) {
                $("#save_button").html(oldText);
            }, 2000);

-            TABS.vtx.initialize();
+            setTimeout(() => TABS.vtx.initialize, 3000); // Allow firmware to make relevant changes before initialization


What about to include it in in the setTimeout for the save button that is just before and increase the timeout of it? At least in this way, you know that the tab will be refreshed at the same time than the button, seems more "solid" for me.

Another solution a little more ellaborated is to use more button messages:

The button contains "Save". The users pushes it.

We change the text to "Saving..." and start the save process.

In this part of code, after all has been saved, we start the initialize with a timeout of 3 seconds.

After the timeout we change the save to "Saved" with a timeout of 2 seconds.

After this timeout we change the text to "Save" again.

In this way is clear that we are saving and refreshing. It uses the same two timeout than now but in different order and calling one inside the other, and we only need to add the new "Saving..." message.

I guess 4 seconds will be enough so making them the same the buttons updates more linear.

sonarqubecloud · 2022-10-07T22:45:05Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

github-actions · 2022-10-07T22:52:44Z

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

McGiverGim

It's not exactly what I susggested but it's ok.

haslinghuis · 2022-10-08T17:18:15Z

Curious to see your version as I used your functional design here.

haslinghuis added the RN: BUGFIX label Oct 6, 2022

haslinghuis added this to the 10.9.0 milestone Oct 6, 2022

haslinghuis self-assigned this Oct 6, 2022