RORDEV-1444 user info source methods description #252
Conversation
WalkthroughThe pull request updates the Changes
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
kibana.md (1)
1169-1183: Enhance Clarity foruserInfoSourceDefault Behavior
The new "User Info Source Methods" section provides a clear description of the two available methods for obtaining OIDC user profile information. The YAML snippet example illustrates how to set the option correctly. However, note that the description states thatuser_info_endpoint(default) is used when no value is provided, but the example uses'access_token'. This might confuse readers as to what the default behavior is. Consider adding a brief note explicitly stating that if the parameter is omitted, the plugin will default to usinguser_info_endpoint.
* commit new action strings * [RORDEV-1317] ror-tools patching confirmation docs (#251) Docs * RORDEV-1262 improvements * RORDEV-1262 improvements * RORDEV-1262 Add documentation for extending Kibana API with x-ror-tenancy-id header (#253) * RORDEV-1262 Add documentation for extending Kibana API with x-ror-tenancy-id header * RORDEV-1262 Add info about id * RORDEV-1262 add info about default value * update description * update based on coderabbit suggestions * update message * change endpoint to /tenants * RORDEV-1444 user info source methods description (#252) * RORDEV-1446-Add-support-for-the-passing-any-SAML/OIDC-config-parameters-via-kibana.yml (#256) * RORDEV-1446-Add-support-for-the-passing-any-SAML/OIDC-config-parameters-via-kibana.yml * RORDEV-1446 review comment * commit new action strings * commit new action strings * commit new action strings * commit new action strings * RORDEV-1262 adjust endpoint * RORDEV-1262 cr comments resolving * RORDEV-1262 improvements * RORDEV-1262 improvements * update description * update based on coderabbit suggestions * update message * change endpoint to /tenants * RORDEV-1262 adjust endpoint * RORDEV-1262 cr comments resolving * RORDEV-1262 change example * RORDEV-1262 change all tenants to user's tenants * RORDEV-1262 change methods --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: mgoworko <37329559+mgoworko@users.noreply.github.com>
Summary by CodeRabbit
userInfoSourcewith an illustrative example to assist users in setup, while retaining existing client authentication instructions.