Fix order of import statements for shapely issue#23
Open
stweil wants to merge 1 commit intobertsky:masterfrom
Open
Fix order of import statements for shapely issue#23stweil wants to merge 1 commit intobertsky:masterfrom
stweil wants to merge 1 commit intobertsky:masterfrom
Conversation
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Contributor
Author
|
It's true that such less obvious imports make it difficult to find all affected code locations by a simple code inspection. But it would still be possible to fix the issue like that case by case. The current workaround to run |
Owner
|
I agree in principle. But we know that core itself, which is used everywhere (CLI decorators), always imports shapely (via ocrd_validators, via ocrd) – before anything else. So that would need to be solved first... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.