Turn off fast log (triton-lang#4777)

Temporarily turn off log for now to deal with precision problem.
bertmaher · Dec 6, 2024 · 6d2b31f · 6d2b31f
1 parent e3b1089
commit 6d2b31f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/python/src/ir.cc b/python/src/ir.cc
@@ -1469,7 +1469,8 @@ void init_triton_ir(py::module &&m) {
            })
       .def("create_log",
            [](TritonOpBuilder &self, Value &val) -> Value {
-             return approxMath(self.create<math::LogOp>(val));
+             // TODO: switch to approxMath.
+             return self.create<math::LogOp>(val);
            })
       .def("create_log2",
            [](TritonOpBuilder &self, Value &val) -> Value {

diff --git a/python/test/unit/language/test_core.py b/python/test/unit/language/test_core.py
@@ -4385,7 +4385,7 @@ def kernel(X, Y, BLOCK: tl.constexpr):
     k = kernel[(1, )](x, y, BLOCK=shape[0])
     torch.allclose(getattr(torch, func_str)(x), y, rtol=1e-3)
 
-    if func_str in ['log', 'log2'] and is_cuda():
+    if func_str in ['log2'] and is_cuda():
         assert 'lg2.approx.ftz.f32' in k.asm['ptx']
     if func_str in ['exp', 'exp2'] and is_cuda():
         assert 'ex2.approx.ftz.f32' in k.asm['ptx']