Skip to content

Fix exception when the --env argument was missing. #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix exception when the --env argument was missing. #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1ef1b7
Fix exception when the --env argument was missing.
tomas789 Sep 8, 2023
1144361
Bump patch version
tomas789 Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .bumpversion.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 1.2.3
current_version = 1.2.4-rc0
commit = False
tag = False
parse = (?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)\-{0,1}(?P<release>\D*)(?P<build>\d*)
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,6 @@
packages=find_packages(exclude=["ssh_ipykernel_interrupt"]),
python_requires=">=3.5",
url="https://github.com/bernhard-42/ssh_ipykernel",
version="1.2.3",
version="1.2.4-rc0",
zip_safe=False,
)
2 changes: 1 addition & 1 deletion ssh_ipykernel/_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ def get_version(version):
return VersionInfo(major, minor, patch, release, build)


__version__ = "1.2.3" # DO NOT EDIT THIS DIRECTLY! It is managed by bumpversion
__version__ = "1.2.4-rc0" # DO NOT EDIT THIS DIRECTLY! It is managed by bumpversion
__version_info__ = get_version(__version__)
3 changes: 1 addition & 2 deletions ssh_ipykernel/manage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,7 @@ def simplify(name):
required.add_argument("--python", "-p", required=True, help="remote python_path")
args = parser.parse_args()

if args.env:
env = " ".join(args.env)
env = " ".join(args.env if args.env else [])

add_kernel(
host=args.host,
Expand Down