Update script to support buildFeature block #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That looks great! Should I merge? You opened as a draft. |
|
Sorry I wasn't expecting such a quick response I was going to add a TODO 😅 Currently this supports all buildFeatures except compose and just adding it to |
WhosNickDoglio
force-pushed
the
ndoglio-buildfeatures
branch
5 times, most recently
from
636b4c4 to
8d9e8e9
Compare
WhosNickDoglio
force-pushed
the
ndoglio-buildfeatures
branch
2 times, most recently
from
b6d5533 to
fe15dd2
Compare
WhosNickDoglio
force-pushed
the
ndoglio-buildfeatures
branch
2 times, most recently
from
1f20367 to
951c2b2
Compare
WhosNickDoglio
force-pushed
the
ndoglio-buildfeatures
branch
from
951c2b2 to
1c4e20b
Compare
|
@bernaferrari this is now ready for review whenever you get a chance 👍 |
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for converting the
buildFeaturesblock!I'm bad at regex so instead of updating
addEqualsto better filter out false positives I created a newconvertBuildFeaturesfunction at the end that will look for all the buildFeatures and what they're set to and then update them to include the equals.Let me know if this is okay or if you'd preview something a little smarter 😅