-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rest): first implementation #150
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've read through this, and I love that this is doable in only a few hundred lines of code, most of which are docs.
I wish that some of what you had to do here wasn't necessary (redefining schemas and tables and arrays) and I have some ideas about them, but not the time to write them all down here and now.
Eventually, I will have some changes to suggest, but until then I wanted to send encouraging thoughts and appreciation for you taking this on. It's super, super awesome! 🎂
I was thinking too that some redefine like for the table etc wasn't necessary but this library just extend various classes and they are not connected each other so those data are not shared. During the development of this integration I saw this issue in that PR:
|
I was forgetting a little things, I just configured the doc comments for 3.0.0 release. I still waiting for a review as I am curious for feedback :-D |
In the meantime I am using my fork in a plugin I am working on, so I have another test field. |
Haven't forgotten about this. 👋 Just been busy working on other 3.0 changes to hopefully make your work easier to merge/adopt. 🍕 |
Thanks I just used BerlinDB in this period #23 as per that ticket and I think that the example need improvements until the documentation is not out there. |
just a ping |
Can't wait to see this merged too. If you need some help to run tests or everything ✋🏻✋🏻✋🏻 |
ping |
Ref: #26
For an example to test it https://github.com/Mte90/berlindb-rest/
I will update the example when will be merged https://github.com/berlindb/wordpress-example