-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable RTC again in D-Lab hub #4371
Conversation
Ref #4223 |
Thanks! As soon as this is ready let me know and we'll test it out! |
@aculich Looks like we have some complications with enabling RTC in D-lab hub. We need to upgrade the following packages to make RTC work in the D-Lab hub.
However, the D-Lab hub shares the image with the main Datahub. These upgrades are unsafe and may impact instructors who use the main Datahub. The other option is to use Stat 159 hub's image so that you can get these packages along with the corresponding versions. However, Stat 159 image is primarily python specific. Do you require R packages for the D-Lab hub? I am assuming yes by looking at the workshop list here. Please do clarify. If you require R packages then we need to provision a new image for D-Lab hub which might take sometime as there aren't enough cycles this sprint. |
@balajialg Yes, we do need to continue having R support. I'm wondering if maybe we should create a dev/testing instance alongside our current one? Maybe: dlab-testing.datahub.berkeley.edu So that way we can easily test out breaking changes like this before deploying to our main hub? Maybe we could even set up a blue green deployment, since I think we'll be doing this kind of bleeding edge testing more and more in the future with other features or images. In any case, we don't want to break existing compatibility for our workshops happening right now. So a separate testing environment would be handy— and we might even pilot a workshop or two using it at some point sooner. Most of the github repos that we're using come from one place: https://github.com/dlab-berkeley/ |
Also, if we do need to switch over the existing hub, we have a window of time from Thu March 16 through Friday March 24th to do it because we have no workshop happening between those dates (starting back up again 4pm March 27th for an R workshop). |
@aculich Thanks for sharing the detailed requirements! I created an issue for to explore this requirement in detail (#4375) and evaluate whether creating a new hub is the way forward. You can track further updates about this requirement there. I added the Stat 159 image to D-Lab hub as part of my latest commit. Would it be possible for anyone from your team to add/install the required R packages and RStudio to this image? This image already has all the RTC related changes. That will make it easy at our end. Please let me know if that's feasible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than my previous comment, lgtm
@@ -0,0 +1,114 @@ | |||
name: stat159-s23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should probably change this...
@aculich Any updates on this particular request? RTC changes are currently enabled as part of this PR and only the R-related changes to the image (Adding R packages + RStudio) are pending. Does anyone from your team have the bandwidth to help with this requirement? |
@psachdeva can you try testing it out and let Balaji know if you have any issues or requests for packages updates? |
@balajialg how would @psachdeva test this out? I see this PR says "Merging is blocked" and Pratik says he doesn't see it active in our hub. |
Happy to hop on a huddle if we need to discuss further. |
@pssachdeva @aculich I have set up a meeting on Friday to talk through this (next available slot I could find in bcal). Merging rights are currently available only for hub admins and that is the reason why it appears "Merging is blocked". We can talk during this meeting about providing merge access in the Datahub repo. The next steps for this PR are, a) Make image changes as a PR that includes R packages and RStudio in the D-Lab image |
@aculich @pssachdeva Closing this PR in favor of #4484 |
No description provided.