-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update JupyterLab and mystjs extension #4217
Conversation
Lab 3.6.1 adds RTC support - if the package update goes smoothly, we'll test the actual RTC functionality next. The mystjs plugin fixes some pretty critical bugs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@balajialg This is a minor change in terms of configuration, but it will have major consequences as it will enable support for real-time collaboration between users. Excited to see how it turns out.
@fperez To turn on RTC I think it also needs an alteration to the jupyterhub-singleuser command. Did you just want to update lab for now or also enable RTC?
Previously the hub config specified:
singleuser:
cmd:
- jupyterhub-singleuser
- --LabApp.collaborative=true
The jupyterlab-links-share extension was also enabled. Should these be added as well? Previous related commits:
@ryanlovett Yes - super excited about this PR. If @fperez has a good time using RTC this semester then folks who expressed interest to use RTC like this will explore RTC next semester (or maybe even earlier) |
CI failed with: ``` Problem: package jupyterlab-3.6.1-pyhd8ed1ab_0 requires jupyterlab_server >=2.19,<3, but none of the providers can be installed ```
CI failed with
I've added jupyterlab_server as an explicit dependency (it is available in conda-forge), but I wonder if that will be sufficient to make mamba happy. Let's see. |
@fperez I tracked this down to a few conflicts. In a dev environment, besides jupyterlab needing jupyterlab_server==2.19.0, I found:
After those updates and removing jupyter-book, mamba was happy with the resulting environment. But I'm not sure how important jupyter-book is to your stack, so I haven't modified the PR further. |
Regarding jupyter-book, I think we just need jupyter-book/jupyter-book@48fb2fa so I resolved that by using jupyter-book master. |
Thanks for tracking this down @ryanlovett! I pinged the JuptyerBook team to see how viable it would be for them to make a quick release so we can work off an official package rather than a git endpoint. |
Note @ryanlovett that @choldgraf kindly made a 0.13.2 release just for us! We should be able to update to that from conda-forge shortly, which is wonderful. Huge, huge ❤️ 🙏 to Chris!! |
Ah, even better. This has been merged to staging (so you can test there if you want) but I'll prep a new PR once the release is in conda-forge. |
Just a note that if anybody on this team would be willing to help with Jupyter Book (and its underlying stack) maintenance, I am happy to give commit rights! Those projects are very under-resourced right now, and I won't be around in a few weeks to make releases just before bedtime (I'm expecting baby 2!) |
Hey @choldgraf Congratulations :) that's awesome news! Curious to know the kind of tasks you are expecting the maintainers to perform? I can help out in the interim but not sure whether I could do the technical wizardry that @ryanlovett exhibits. |
Lab 3.6.1 adds RTC support - if the package update goes smoothly, we'll test the actual RTC functionality next.
The mystjs plugin fixes some pretty critical bugs.