Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable RTC on stat159 hub #3287

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

yuvipanda
Copy link
Contributor

https://uctech.slack.com/archives/CC3NKQA3B/p1646276416672839
@fperez encountered serious data corruption bugs, that
we suspect is caused by enabling collaborative editing.
Let's turn it off and see if it goes away?

https://uctech.slack.com/archives/CC3NKQA3B/p1646276416672839
@fperez encountered serious data corruption bugs, that
we suspect is caused by enabling collaborative editing.
Let's turn it off and see if it goes away?
@yuvipanda yuvipanda merged commit 2619d85 into berkeley-dsep-infra:staging Mar 3, 2022
yuvipanda added a commit that referenced this pull request Mar 3, 2022
@fperez
Copy link
Collaborator

fperez commented Mar 3, 2022

Just filed a JLab issue so we can track it further there with the Lab team.

@fperez
Copy link
Collaborator

fperez commented Mar 3, 2022

Thanks a lot @yuvipanda for the fast response!

@balajialg
Copy link
Contributor

balajialg commented Mar 3, 2022

Thanks, @yuvipanda for quickly looking into this! Sorry, @fperez that you had to face these issues when the classes are going on.
One question to think about is - If RTC seems to be the root cause for all these issues, then will that be the end of the road for testing RTC this semester? I know that we will report this issue in the respective channel but wondering whether the benefits of re-enabling RTC (if the issues are fixed) is worth the risks associated with data loss.

yuvipanda added a commit to yuvipanda/datahub that referenced this pull request Mar 3, 2022
Follow-up to berkeley-dsep-infra#3287,
as we invesetigate wether some file corruption issues are related
to RTC or not.
@fperez
Copy link
Collaborator

fperez commented Mar 3, 2022

Probably, @balajialg, though we should evaluate carefully. For stat159 specifically there is huge benefit in having RTC, and I was very much looking to use it a lot. But after this week's problems I'm very worried. Let's see what the JLab team's response and feedback are - if a clear cause is identified and corrected, we could do some light trials - I have a separate research hub where I work with my research students and colleagues (that @yuvipanda has access to) and we could do some testing there.

So I'm not quite sure yet - I'm torn between really wanting it for valid pedagogical reasons, and being very worried about potentially losing student work. If there's any lingering doubt of that happening I'll have to be conservative, so let's just keep a close eye on this and see how things evolve.

@yuvipanda yuvipanda mentioned this pull request Mar 3, 2022
@balajialg
Copy link
Contributor

balajialg commented Mar 3, 2022

@fperez Makes sense! I agree that losing students work poses to be a huge risk so need to be conservative with regards to the final decision. Good to know that there is a plan B (testing it out in the research hub) if choosing to be conservative is our choice! Fingers crossed with regards to JLab team's response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants