chore: remove canUseDom with isBrowser (alibaba#1753)

Co-authored-by: huangcheng <huangcheng.lq@bytedance.com>
beriny · Jul 19, 2022 · d09c9d8 · d09c9d8
1 parent 472dd83
commit d09c9d8
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 11 deletions.
diff --git a/packages/hooks/src/useRequest/src/utils/isDocumentVisible.ts b/packages/hooks/src/useRequest/src/utils/isDocumentVisible.ts
@@ -1,7 +1,7 @@
-import canUseDom from '../../../utils/canUseDom';
+import isBrowser from '../../../utils/isBrowser';
 
 export default function isDocumentVisible(): boolean {
-  if (canUseDom()) {
+  if (isBrowser) {
     return document.visibilityState !== 'hidden';
   }
   return true;

diff --git a/packages/hooks/src/useRequest/src/utils/isOnline.ts b/packages/hooks/src/useRequest/src/utils/isOnline.ts
@@ -1,7 +1,7 @@
-import canUseDom from '../../../utils/canUseDom';
+import isBrowser from '../../../utils/isBrowser';
 
 export default function isOnline(): boolean {
-  if (canUseDom() && typeof navigator.onLine !== 'undefined') {
+  if (isBrowser && typeof navigator.onLine !== 'undefined') {
     return navigator.onLine;
   }
   return true;

diff --git a/packages/hooks/src/useRequest/src/utils/subscribeFocus.ts b/packages/hooks/src/useRequest/src/utils/subscribeFocus.ts
@@ -1,5 +1,5 @@
 // from swr
-import canUseDom from '../../../utils/canUseDom';
+import isBrowser from '../../../utils/isBrowser';
 import isDocumentVisible from './isDocumentVisible';
 import isOnline from './isOnline';
 
@@ -13,7 +13,7 @@ function subscribe(listener: () => void) {
   };
 }
 
-if (canUseDom()) {
+if (isBrowser) {
   const revalidate = () => {
     if (!isDocumentVisible() || !isOnline()) return;
     for (let i = 0; i < listeners.length; i++) {

diff --git a/packages/hooks/src/useRequest/src/utils/subscribeReVisible.ts b/packages/hooks/src/useRequest/src/utils/subscribeReVisible.ts
@@ -1,4 +1,4 @@
-import canUseDom from '../../../utils/canUseDom';
+import isBrowser from '../../../utils/isBrowser';
 import isDocumentVisible from './isDocumentVisible';
 
 const listeners: any[] = [];
@@ -11,7 +11,7 @@ function subscribe(listener: () => void) {
   };
 }
 
-if (canUseDom()) {
+if (isBrowser) {
   const revalidate = () => {
     if (!isDocumentVisible()) return;
     for (let i = 0; i < listeners.length; i++) {

diff --git a/packages/hooks/src/utils/canUseDom.ts b/packages/hooks/src/utils/canUseDom.ts