Skip to content

Conversation

@ferdinandyb
Copy link

According to the RFC, the correct value for an undefined priority is 0, not an empty string. The caldav package definitely chokes on non-int priorities making it to server-side, when trying to download them.

Link: https://datatracker.ietf.org/doc/html/rfc5545#section-3.8.1.9

Description

Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context. List any dependencies that are required
for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details for your
test configuration

  • I checked in nextcloud and the Tasks android app that indeed "no priority" is priority=0, so at least these two applications take the RFC seriously
  • I enable checking priority for caldav items, so now the test will fail if the priority is not 0 or one of the mapped numbers

Checklist

N/A is striked through

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] Any dependent changes have been merged and published in downstream modules

According to the RFC, the correct value for an undefined priority is 0,
not an empty string. The `caldav` package definitely chokes on non-int
priorities making it to server-side, when trying to download them.

Link: https://datatracker.ietf.org/doc/html/rfc5545#section-3.8.1.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant