fix: Add additional global config path on macos #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I can confirm it works. I placed the config at 
|
Great, thank you! |
WillLillis
force-pushed
the
macos_config_dir
branch
from
71cf238 to
7c8574f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the server uses the
dirscrate to find the global configuration path. On MacOS this is unintuitively$HOME/Library/Application Support/. This PR adds$HOME/.configas an additional directory to search if the first check comes up empty.cc @JezerM I don't have a Mac to test this locally. If you have the time, could you check if this resolves the behavior outlined in #127?
EDIT: Not sure why CI is failing, everything is passing locally in Ubuntu. Give me a minute to work this out :)