Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic allocation of effect slots #108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

poisotf
Copy link

@poisotf poisotf commented Oct 11, 2024

Supersedes #107
Following tests + USB capture of g923 on Windows, in an effort to match Windows driver behaviour :

This replaces the static allocation of hardware slots for particular effect types, with a "first come first served" scheme that can shuffle types.

There is also effect type fixup of FF_INERTIA and FF_FRICTION into "damper"

Different effects cannot be summed within one hardware slot, but several slots can be active with the same effect type.
On my unit, playing 3 slots of "damper" feels not great, but reasonable (correct result, with loss of precision and mild motor whine)

This should accept more diverse usage patterns from games before dropping effects.
#107 is already not dropping effects on any game I own, though.

I considered adding an extra gain knob for "inertia", but I'm not convinced this effect has a point. The "damper" gain is applied for now

This is similar to what the Windows driver does.
Allows playing several similar effects at once, and to expose
FF_INERTIA.
@berarma
Copy link
Owner

berarma commented Oct 30, 2024

Sorry for the delay. It looks good. I'll try to give it some testing soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants