Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #107
Following tests + USB capture of g923 on Windows, in an effort to match Windows driver behaviour :
This replaces the static allocation of hardware slots for particular effect types, with a "first come first served" scheme that can shuffle types.
There is also effect type fixup of FF_INERTIA and FF_FRICTION into "damper"
Different effects cannot be summed within one hardware slot, but several slots can be active with the same effect type.
On my unit, playing 3 slots of "damper" feels not great, but reasonable (correct result, with loss of precision and mild motor whine)
This should accept more diverse usage patterns from games before dropping effects.
#107 is already not dropping effects on any game I own, though.
I considered adding an extra gain knob for "inertia", but I'm not convinced this effect has a point. The "damper" gain is applied for now