This repository was archived by the owner on Oct 27, 2023. It is now read-only.
Dev 978 proposal created by wallet only user doesnt show the wallet #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w-the-wallet-address-in-the-proposal-page-hero' of https://github.com/vhcsilva/web-network into DEV-978-proposal-created-by-wallet-only-user-doesnt-show-the-wallet
clarkjoao
approved these changes
Jan 3, 2023
moshmage
approved these changes
Jan 4, 2023
moshmage
added a commit
that referenced
this pull request
Jan 6, 2023
### Fix - DEV-1142 If approval missing or conflicts, merge button can't be enabled - DEV-1158 after creating a proposal without github Login connected - DEV-1223 When reading old events on getBountyClosedEvents webnetwork-events fails - DEV-1102 Past events of network registry are not filtered by the registry address - DEV-976 Bounty roadmap is showing "validation & disputes" without proposals - DEV-978 Proposal by wallet only user _now_ shows the wallet address in the proposal page hero - DEV-1135 show loading modal when user connect GH account - DEV-1184 Custom networks - Visual bugs - DEV-1185 adding a new token after network is created does not fire past-events change registry events - DEV-1205 Size limit warning is displayed in the "Review" step - DEV-1212 After close a network and try to create a new one the network's name isn't validated - DEV-1213 Big titles without space between words breaks UI - DEV-1218 Percentage needed for dispute changes but no save button appears (on my network) ### Changes - DEV-1171 change bounty json to match ERC721 metadata - DEV-1144 add "approve pr" button to proposal actions if PR needs approval - DEV-956 Remove bot user from create proposal modal participants - DEV-1200 get curator status from database (along with oracles amount, etc) - DEV-1211 implement primer/css/markdown into the "preview" stage of bounty creation and bounty page - DEV-1216 Move "Close Network" btn from "Logo & Colours" to "Governance" tab ### New - DEV-1210 re-authorize github connection flow --- * DEV-976 fix bounty roadmap (#779) * DEV-976 fix bounty roadmap * DEV-976 fix network params * Dev 1152 review pull requests using web app (#780) * updating route from developers to bounties * fixes * adding viewer perm and branch protection rules * fix * fix * disable merge btn if pr need approval * fix eslint warnings * adding approve btn on item row * set bot as admin * adding translation * only show btn when pull request * fix * removing unused * Dev 1210 re authorize GitHub connection (#782) * changing to 5 minutes to test * changing to 2 minutes * verifying and showing modal * adding translations * centering btn * 30 days again * Dev 1185 fix update network tokens (#778) * DEV-1185 fix update network tokens * DEV-1185 add getnetworktokens endpoint * DEV-1185 fix network tokens select * DEV-1185 fix type * DEV-1185 remove debugger * DEV-1185 remove unused func * fix (#781) * Dev 1211 implement primer css markdown into the preview stage of bounty creation and bounty page (#784) * testing primer * test * adding preview Co-authored-by: clarkjoao <46800211+clarkjoao@users.noreply.github.com> * fix (#787) * fix (#786) Co-authored-by: Marcus Vinícius <marcusvinici25@gmail.com> * adding target _blank (#788) Co-authored-by: Marcus Vinícius <marcusvinici25@gmail.com> * DEV-1216 move close network btn to governance tab (#789) * DEV-1135 add spinner when connect gh (#792) * DEV-1212 fix deep copy settings (#791) * DEV-1212 fix deep copy settings * DEV-1212 remove duplicate comment * Dev 1218 percentage needed for dispute changes but no save button appears (#793) * creating warning github component * adding translations * adding warningGithub component to my-network page * Dev 1184 custom networks visual bugs (#795) * adjusting height Logo * removing settings because not working in aurora * adjusting to get background default * DEV-1172 change nft json (#796) * DEV-1172 change nft json * DEV-1171 fix issue id * Dev 1200 get curator status from database along with oracles amount etc (#794) * adjusting logic to get staked on database * removing eth to balance interface * adjusting to save all oracles on database * rm console * fix (#800) Co-authored-by: Vitor Hugo <vhcsilvaa@gmail.com> * improve read code tokens settings (#799) * Dev 1252 add polygon rpc info to config (#801) * adding Polygon network * adding polygon color Co-authored-by: clarkjoao <46800211+clarkjoao@users.noreply.github.com> Co-authored-by: Vitor Hugo <vhcsilvaa@gmail.com> Co-authored-by: Marcus Vinícius <marcusvinici25@gmail.com>
clarkjoao
added a commit
that referenced
this pull request
Jan 9, 2023
* DEV-976 fix bounty roadmap (#779) * DEV-976 fix bounty roadmap * DEV-976 fix network params * Dev 1152 review pull requests using web app (#780) * updating route from developers to bounties * fixes * adding viewer perm and branch protection rules * fix * fix * disable merge btn if pr need approval * fix eslint warnings * adding approve btn on item row * set bot as admin * adding translation * only show btn when pull request * fix * removing unused * Dev 1210 re authorize GitHub connection (#782) * changing to 5 minutes to test * changing to 2 minutes * verifying and showing modal * adding translations * centering btn * 30 days again * Dev 1185 fix update network tokens (#778) * DEV-1185 fix update network tokens * DEV-1185 add getnetworktokens endpoint * DEV-1185 fix network tokens select * DEV-1185 fix type * DEV-1185 remove debugger * DEV-1185 remove unused func * fix (#781) * Dev 1211 implement primer css markdown into the preview stage of bounty creation and bounty page (#784) * testing primer * test * adding preview Co-authored-by: clarkjoao <46800211+clarkjoao@users.noreply.github.com> * fix (#787) * fix (#786) Co-authored-by: Marcus Vinícius <marcusvinici25@gmail.com> * adding target _blank (#788) Co-authored-by: Marcus Vinícius <marcusvinici25@gmail.com> * DEV-1216 move close network btn to governance tab (#789) * DEV-1135 add spinner when connect gh (#792) * DEV-1212 fix deep copy settings (#791) * DEV-1212 fix deep copy settings * DEV-1212 remove duplicate comment * Dev 1218 percentage needed for dispute changes but no save button appears (#793) * creating warning github component * adding translations * adding warningGithub component to my-network page * Dev 1184 custom networks visual bugs (#795) * adjusting height Logo * removing settings because not working in aurora * adjusting to get background default * DEV-1172 change nft json (#796) * DEV-1172 change nft json * DEV-1171 fix issue id * Dev 1200 get curator status from database along with oracles amount etc (#794) * adjusting logic to get staked on database * removing eth to balance interface * adjusting to save all oracles on database * rm console * fix (#800) Co-authored-by: Vitor Hugo <vhcsilvaa@gmail.com> * improve read code tokens settings (#799) * DEV-1274 add admin routes middleware Co-authored-by: Vitor Hugo <vhcsilvaa@gmail.com> Co-authored-by: Marcus Vinícius <marcusvinici25@gmail.com>
clarkjoao
added a commit
to clarkjoao/web-network
that referenced
this pull request
Jan 10, 2023
* DEV-976 fix bounty roadmap (bepronetwork#779) * DEV-976 fix bounty roadmap * DEV-976 fix network params * Dev 1152 review pull requests using web app (bepronetwork#780) * updating route from developers to bounties * fixes * adding viewer perm and branch protection rules * fix * fix * disable merge btn if pr need approval * fix eslint warnings * adding approve btn on item row * set bot as admin * adding translation * only show btn when pull request * fix * removing unused * Dev 1210 re authorize GitHub connection (bepronetwork#782) * changing to 5 minutes to test * changing to 2 minutes * verifying and showing modal * adding translations * centering btn * 30 days again * Dev 1185 fix update network tokens (bepronetwork#778) * DEV-1185 fix update network tokens * DEV-1185 add getnetworktokens endpoint * DEV-1185 fix network tokens select * DEV-1185 fix type * DEV-1185 remove debugger * DEV-1185 remove unused func * fix (bepronetwork#781) * Dev 1211 implement primer css markdown into the preview stage of bounty creation and bounty page (bepronetwork#784) * testing primer * test * adding preview Co-authored-by: clarkjoao <46800211+clarkjoao@users.noreply.github.com> * fix (bepronetwork#787) * fix (bepronetwork#786) Co-authored-by: Marcus Vinícius <marcusvinici25@gmail.com> * adding target _blank (bepronetwork#788) Co-authored-by: Marcus Vinícius <marcusvinici25@gmail.com> * DEV-1216 move close network btn to governance tab (bepronetwork#789) * DEV-1135 add spinner when connect gh (bepronetwork#792) * DEV-1212 fix deep copy settings (bepronetwork#791) * DEV-1212 fix deep copy settings * DEV-1212 remove duplicate comment * Dev 1218 percentage needed for dispute changes but no save button appears (bepronetwork#793) * creating warning github component * adding translations * adding warningGithub component to my-network page * Dev 1184 custom networks visual bugs (bepronetwork#795) * adjusting height Logo * removing settings because not working in aurora * adjusting to get background default * DEV-1172 change nft json (bepronetwork#796) * DEV-1172 change nft json * DEV-1171 fix issue id * Dev 1200 get curator status from database along with oracles amount etc (bepronetwork#794) * adjusting logic to get staked on database * removing eth to balance interface * adjusting to save all oracles on database * rm console * fix (bepronetwork#800) Co-authored-by: Vitor Hugo <vhcsilvaa@gmail.com> * improve read code tokens settings (bepronetwork#799) * DEV-1274 add admin routes middleware Co-authored-by: Vitor Hugo <vhcsilvaa@gmail.com> Co-authored-by: Marcus Vinícius <marcusvinici25@gmail.com>
clarkjoao
added a commit
that referenced
this pull request
Jan 17, 2023
* DEV-976 fix bounty roadmap (#779) * DEV-976 fix bounty roadmap * DEV-976 fix network params * Dev 1152 review pull requests using web app (#780) * updating route from developers to bounties * fixes * adding viewer perm and branch protection rules * fix * fix * disable merge btn if pr need approval * fix eslint warnings * adding approve btn on item row * set bot as admin * adding translation * only show btn when pull request * fix * removing unused * Dev 1210 re authorize GitHub connection (#782) * changing to 5 minutes to test * changing to 2 minutes * verifying and showing modal * adding translations * centering btn * 30 days again * Dev 1185 fix update network tokens (#778) * DEV-1185 fix update network tokens * DEV-1185 add getnetworktokens endpoint * DEV-1185 fix network tokens select * DEV-1185 fix type * DEV-1185 remove debugger * DEV-1185 remove unused func * fix (#781) * Dev 1211 implement primer css markdown into the preview stage of bounty creation and bounty page (#784) * testing primer * test * adding preview Co-authored-by: clarkjoao <46800211+clarkjoao@users.noreply.github.com> * fix (#787) * fix (#786) Co-authored-by: Marcus Vinícius <marcusvinici25@gmail.com> * adding target _blank (#788) Co-authored-by: Marcus Vinícius <marcusvinici25@gmail.com> * DEV-1216 move close network btn to governance tab (#789) * DEV-1135 add spinner when connect gh (#792) * DEV-1212 fix deep copy settings (#791) * DEV-1212 fix deep copy settings * DEV-1212 remove duplicate comment * Dev 1218 percentage needed for dispute changes but no save button appears (#793) * creating warning github component * adding translations * adding warningGithub component to my-network page * Dev 1184 custom networks visual bugs (#795) * adjusting height Logo * removing settings because not working in aurora * adjusting to get background default * DEV-1172 change nft json (#796) * DEV-1172 change nft json * DEV-1171 fix issue id * Dev 1200 get curator status from database along with oracles amount etc (#794) * adjusting logic to get staked on database * removing eth to balance interface * adjusting to save all oracles on database * rm console * fix (#800) Co-authored-by: Vitor Hugo <vhcsilvaa@gmail.com> * improve read code tokens settings (#799) * hotfix handler network Co-authored-by: Vitor Hugo <vhcsilvaa@gmail.com> Co-authored-by: Marcus Vinícius <marcusvinici25@gmail.com>
moshmage
pushed a commit
that referenced
this pull request
Jan 18, 2023
* DEV-976 fix bounty roadmap (#779) * DEV-976 fix bounty roadmap * DEV-976 fix network params * Dev 1152 review pull requests using web app (#780) * updating route from developers to bounties * fixes * adding viewer perm and branch protection rules * fix * fix * disable merge btn if pr need approval * fix eslint warnings * adding approve btn on item row * set bot as admin * adding translation * only show btn when pull request * fix * removing unused * Dev 1210 re authorize GitHub connection (#782) * changing to 5 minutes to test * changing to 2 minutes * verifying and showing modal * adding translations * centering btn * 30 days again * Dev 1185 fix update network tokens (#778) * DEV-1185 fix update network tokens * DEV-1185 add getnetworktokens endpoint * DEV-1185 fix network tokens select * DEV-1185 fix type * DEV-1185 remove debugger * DEV-1185 remove unused func * fix (#781) * Dev 1211 implement primer css markdown into the preview stage of bounty creation and bounty page (#784) * testing primer * test * adding preview Co-authored-by: clarkjoao <46800211+clarkjoao@users.noreply.github.com> * fix (#787) * fix (#786) Co-authored-by: Marcus Vinícius <marcusvinici25@gmail.com> * adding target _blank (#788) Co-authored-by: Marcus Vinícius <marcusvinici25@gmail.com> * DEV-1216 move close network btn to governance tab (#789) * DEV-1135 add spinner when connect gh (#792) * DEV-1212 fix deep copy settings (#791) * DEV-1212 fix deep copy settings * DEV-1212 remove duplicate comment * Dev 1218 percentage needed for dispute changes but no save button appears (#793) * creating warning github component * adding translations * adding warningGithub component to my-network page * Dev 1184 custom networks visual bugs (#795) * adjusting height Logo * removing settings because not working in aurora * adjusting to get background default * DEV-1172 change nft json (#796) * DEV-1172 change nft json * DEV-1171 fix issue id * Dev 1200 get curator status from database along with oracles amount etc (#794) * adjusting logic to get staked on database * removing eth to balance interface * adjusting to save all oracles on database * rm console * fix (#800) Co-authored-by: Vitor Hugo <vhcsilvaa@gmail.com> * improve read code tokens settings (#799) * DEV-1274 add admin routes middleware Co-authored-by: Vitor Hugo <vhcsilvaa@gmail.com> Co-authored-by: Marcus Vinícius <marcusvinici25@gmail.com>
moshmage
pushed a commit
that referenced
this pull request
Jan 18, 2023
* DEV-976 fix bounty roadmap (#779) * DEV-976 fix bounty roadmap * DEV-976 fix network params * Dev 1152 review pull requests using web app (#780) * updating route from developers to bounties * fixes * adding viewer perm and branch protection rules * fix * fix * disable merge btn if pr need approval * fix eslint warnings * adding approve btn on item row * set bot as admin * adding translation * only show btn when pull request * fix * removing unused * Dev 1210 re authorize GitHub connection (#782) * changing to 5 minutes to test * changing to 2 minutes * verifying and showing modal * adding translations * centering btn * 30 days again * Dev 1185 fix update network tokens (#778) * DEV-1185 fix update network tokens * DEV-1185 add getnetworktokens endpoint * DEV-1185 fix network tokens select * DEV-1185 fix type * DEV-1185 remove debugger * DEV-1185 remove unused func * fix (#781) * Dev 1211 implement primer css markdown into the preview stage of bounty creation and bounty page (#784) * testing primer * test * adding preview Co-authored-by: clarkjoao <46800211+clarkjoao@users.noreply.github.com> * fix (#787) * fix (#786) Co-authored-by: Marcus Vinícius <marcusvinici25@gmail.com> * adding target _blank (#788) Co-authored-by: Marcus Vinícius <marcusvinici25@gmail.com> * DEV-1216 move close network btn to governance tab (#789) * DEV-1135 add spinner when connect gh (#792) * DEV-1212 fix deep copy settings (#791) * DEV-1212 fix deep copy settings * DEV-1212 remove duplicate comment * Dev 1218 percentage needed for dispute changes but no save button appears (#793) * creating warning github component * adding translations * adding warningGithub component to my-network page * Dev 1184 custom networks visual bugs (#795) * adjusting height Logo * removing settings because not working in aurora * adjusting to get background default * DEV-1172 change nft json (#796) * DEV-1172 change nft json * DEV-1171 fix issue id * Dev 1200 get curator status from database along with oracles amount etc (#794) * adjusting logic to get staked on database * removing eth to balance interface * adjusting to save all oracles on database * rm console * fix (#800) Co-authored-by: Vitor Hugo <vhcsilvaa@gmail.com> * improve read code tokens settings (#799) * hotfix handler network Co-authored-by: Vitor Hugo <vhcsilvaa@gmail.com> Co-authored-by: Marcus Vinícius <marcusvinici25@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.