Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #36

Merged
merged 3 commits into from
May 21, 2021
Merged

Refactoring #36

merged 3 commits into from
May 21, 2021

Conversation

benyaming
Copy link
Owner

@benyaming benyaming commented May 21, 2021

Removed better_exceptions.py, added betterlogging instead
Added sentry integration

@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #36 (3ef6b68) into master (563a66a) will increase coverage by 0.22%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   98.84%   99.07%   +0.22%     
==========================================
  Files          24       23       -1     
  Lines         782      759      -23     
==========================================
- Hits          773      752      -21     
+ Misses          9        7       -2     
Impacted Files Coverage Δ
zmanim_api/utils.py 93.75% <50.00%> (-6.25%) ⬇️
zmanim_api/main.py 100.00% <100.00%> (ø)
zmanim_api/settings.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42a6b61...3ef6b68. Read the comment docs.

@benyaming benyaming merged commit d8d7b29 into master May 21, 2021
@benyaming benyaming deleted the refactoring branch June 27, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant