feat: emit text-change event when saving back to quill #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaines
force-pushed
the
feature/text-change-event
branch
from
51b6c76 to
597a716
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dangerouslyPasteHTMLcommand unfortunately doesn't trigger thetext-changeevent in quill.This means anything watching the
text-changeevent doesn't get any events from the html editor populating it's content.For our use-case we have an angular form field implementation and found that if users were pasting in the html and not making any changes afterwards then that change would be lost.
This is a simple addition that calls the
text-changeevent with the new html content so anything watching for that event gets the new content and can update accordingly.