Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated auth method #1724

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix deprecated auth method #1724

wants to merge 2 commits into from

Conversation

Zhigalin
Copy link

Fixing this:
https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/
Merge this before 05/05/2021 or the GitHub connection will be broken for everyone

Fixing this:
https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/
Merge this before 05/05/2021 or the GitHub connection will be broken for everyone
@Zhigalin
Copy link
Author

Seems the build failed because of code style problems, now fixed it

@leils
Copy link

leils commented Sep 9, 2021

@benweet please review/merge, this is currently broken.

@MatMasIt
Copy link

This fix is of utmost importance

@nsotnikov
Copy link

nsotnikov commented Sep 25, 2021

@benweet please review/merge, or add people who can take this responsibility.

@hoclun-rigsep
Copy link

Anyone know of a hosted fork? This really throwing a wrench in my team's workflow—it was hard enough getting them off of MS Word in the first place.

@iaeiou
Copy link

iaeiou commented Oct 10, 2021

Note that Gitlab sync works fine

@Flamenco
Copy link
Contributor

This is issue was fixed in StackEditPro.

@qualityshepherd
Copy link

mergy merge please...

@ashutoshsaboo
Copy link

ping! @benweet can you please get this merged? github auth has been broken since long...

@hoclun-rigsep
Copy link

Why was @Flamenco downvoted?

@bendtherules
Copy link

@Zhigalin Merge now please

@MatMasIt
Copy link

MatMasIt commented Jan 1, 2022

If you are not able to handle this kind of events, I suggest you nominate project maintainers for the good of stackedit

@CalebmKopp
Copy link

Fix from @mogoe1 found here

@yangcheng
Copy link

what's the status of the issue?

@ShawnPConroy
Copy link

ShawnPConroy commented Aug 19, 2022

Thanks for this fix. Clearly, @benweet is the maintainer of StackEdit and has been kinda MIA since 2019. He has not be active on the StackEdit community since Jan 2019. Has few commits over the last two year, but a few for this project one month in 2021. And he seems to maintain the website. So this project seems like it's dead. Which is a shame because it's the best online editor and I use it a lot, and it's a shame it's integrations are not working.

This problem has a workaround listed in #1755 you can use. I did this when adding my workspace, and when I close the site and open again it seems to still be working. People may need to re-authorize their account. Also note it defaults to the 'master' branch rather than 'main' branch wish is the new default branch, if you are creating a new work space on a new repository.

houserockr added a commit to houserockr/stackedit that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.