-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecated auth method #1724
base: master
Are you sure you want to change the base?
Conversation
Fixing this: https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/ Merge this before 05/05/2021 or the GitHub connection will be broken for everyone
Seems the build failed because of code style problems, now fixed it |
@benweet please review/merge, this is currently broken. |
This fix is of utmost importance |
@benweet please review/merge, or add people who can take this responsibility. |
Anyone know of a hosted fork? This really throwing a wrench in my team's workflow—it was hard enough getting them off of MS Word in the first place. |
Note that Gitlab sync works fine |
This is issue was fixed in StackEditPro. |
mergy merge please... |
ping! @benweet can you please get this merged? github auth has been broken since long... |
Why was @Flamenco downvoted? |
@Zhigalin Merge now please |
If you are not able to handle this kind of events, I suggest you nominate project maintainers for the good of stackedit |
what's the status of the issue? |
Thanks for this fix. Clearly, @benweet is the maintainer of StackEdit and has been kinda MIA since 2019. He has not be active on the StackEdit community since Jan 2019. Has few commits over the last two year, but a few for this project one month in 2021. And he seems to maintain the website. So this project seems like it's dead. Which is a shame because it's the best online editor and I use it a lot, and it's a shame it's integrations are not working. This problem has a workaround listed in #1755 you can use. I did this when adding my workspace, and when I close the site and open again it seems to still be working. People may need to re-authorize their account. Also note it defaults to the 'master' branch rather than 'main' branch wish is the new default branch, if you are creating a new work space on a new repository. |
Apply github patch benweet#1724
Fixing this:
https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/
Merge this before 05/05/2021 or the GitHub connection will be broken for everyone