Skip to content
This repository has been archived by the owner on Jun 1, 2022. It is now read-only.

Add Mypy Static Type Checking to SDK & Pull latest bentobox-engine image as build cache #61

Merged
merged 27 commits into from
Feb 20, 2021
Merged

Add Mypy Static Type Checking to SDK & Pull latest bentobox-engine image as build cache #61

merged 27 commits into from
Feb 20, 2021

Conversation

mrzzy
Copy link
Collaborator

@mrzzy mrzzy commented Feb 18, 2021 •
edited
Loading

Why we need this PR

Closes #29: Finishes implementing #29.

What this PR does

Add Mypy Static Type Checking:

  • Add mypy to project makefile to lint types when linting SDK.
  • Fix or ignore existing errors flagged by mypy.
  • Add secrets, end of file, trailing whitespace, merge conflict and secrets as pre-commit checks

Pull latest bentobox-engine Docker image as build cache:

  • Adds cache metadata to built images required to use pulled images as cache.
  • Replace docker image caching in favor of just pulling the previous docker image.

@mrzzy mrzzy changed the title SDK: Add Mypy Static Type Checking Add Mypy Static Type Checking to SDK & Pull latest bentobox-engine Docker image as build cache Feb 19, 2021
@mrzzy mrzzy changed the title Add Mypy Static Type Checking to SDK & Pull latest bentobox-engine Docker image as build cache Add Mypy Static Type Checking to SDK & Pull latest bentobox-engine image as build cache Feb 19, 2021
@mrzzy mrzzy added ci/cd Github Actions CI sdk Area: SDK housekeeping labels Feb 19, 2021
@mrzzy
refactor(build): Execute mypy standalone instead of via python -m
d6ead91
@mrzzy
fix(ci): Fix typos causing pull image for cache step to fail, tempora…
cf093b8 
…ry run CD in PR for testing
@mrzzy
fix(sdk): Fix failing mypy due by removing unneeded typing-protobuf p…
787a5fb 
…ackage
@mrzzy
chore(sdk): Remove uneeded type: ignores and clean up types
1dd6339
@mrzzy
fix(build): Fix project makefile's lint-sdk failing due to mypy missi…
46c94f4 
…ng type annoatations for protobuf bindings
@mrzzy
fix(build): Fix missing cache metadata when required to use pulled im…
6ce094a 
…ages as cache
@mrzzy
fix(ci): Fix missing protoc required to run make lint-sdk
87f532d
@mrzzy
refactor(ci): Run lint-sdk as a seperate job from build-test-sdk
e0dca62 
Simplifies as we do not need to support linting on all OSes. linting
only looks for the problems in the codebase which is OS-independent, so
linting on one OS should be sufficient
@mrzzy
fix(ci): Fix build-test-sdk still install protoc and protoc-gen-mypy …
c868527 
…not in PATH
@mrzzy
fix(cd): Fix missing docker tag bentobox-engine image as latest
533dd9d
@mrzzy
chore(ci): Add name to to lint-sdk CI job
ab6914a
@mrzzy
fix(ci): Move GITHUB_PATH setting to previous action in job as PATH i…
0c62daa 
…s only updated for subsequent jobs
@mrzzy
refactor(sdk): Bump numpy to 1.20.1 to get builtin type annotations
95462e1
@mrzzy
fix(ci/cd): Use docker buildkit as docker cache from pulled images on…
bac8f8f 
…ly works for buildkit images
@mrzzy mrzzy added this to the v0.1 milestone Feb 19, 2021
@mrzzy mrzzy merged commit 8bdbaef into master Feb 20, 2021
@mrzzy mrzzy deleted the feat/sdk-type-lint branch February 20, 2021 05:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
ci/cd Github Actions CI housekeeping sdk Area: SDK
Projects
None yet
Milestone
v0.1
Development

Successfully merging this pull request may close these issues.

CD Pipeline: Automated Release Process
1 participant
@mrzzy